Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix explore() with highlight_kwds containing custom style_function #3032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BartoszBiernacki
Copy link

@BartoszBiernacki BartoszBiernacki commented Sep 28, 2023

Fixes #3031

@jorisvandenbossche jorisvandenbossche changed the title Fix BUG #3031 in explore.py BUG: fix explore() with highlight_kwds containing custom style_function Jan 5, 2024
@jorisvandenbossche
Copy link
Member

@BartoszBiernacki Thanks a lot for the PR, and our apologies for the slow follow-up.

Could you add a test for this? (check geopandas/tests/test_explore.py)

You also have a linter failure because of some trailing whitespace. To avoid this kind of issues, I would personally recommend installing the pre-commit hook we have included in the repo which will check and fix those lint issues automatically. See https://geopandas.org/en/latest/community/contributing.html#style-guide-linting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: gdf.explore() method fails when highlight_kwds contains custom style_function
2 participants