Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library / Moment.js / Update to 2.23.0. #3395

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Library / Moment.js / Update to 2.23.0. #3395

merged 1 commit into from
Jan 7, 2019

Conversation

fxprunayre
Copy link
Member

Related to #3387

@fxprunayre fxprunayre added this to the 3.6.0 milestone Jan 4, 2019
@fxprunayre fxprunayre added this to To do in 3.6.0 via automation Jan 4, 2019
PascalLike
PascalLike approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@PascalLike PascalLike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the "humanized" dates in some metadata views and works fine. Is this enough?

@fxprunayre
Copy link
Member Author

I checked the "humanized" dates in some metadata views and works fine. Is this enough?

Yes this is the main usage we are doing of it and in the date directive in the editor. Thanks for the review.

@fxprunayre fxprunayre merged commit 0ae34fb into geonetwork:master Jan 7, 2019
3.6.0 automation moved this from To do to Done Jan 7, 2019
@fxprunayre fxprunayre self-assigned this Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalLike PascalLike PascalLike approved these changes

Assignees

@fxprunayre fxprunayre

Labels
enhancement
Projects
No open projects
3.6.0
  
Done
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fxprunayre @PascalLike