Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another SF 4.2 deprecation #211

Merged
merged 6 commits into from Dec 22, 2018
Merged

Fix another SF 4.2 deprecation #211

merged 6 commits into from Dec 22, 2018

Conversation

xkobal
Copy link
Contributor

@xkobal xkobal commented Dec 11, 2018

A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.

@franmomu
Copy link
Contributor

franmomu commented Dec 16, 2018

This bundle supports symfony/framework-bundle": "^3.3 || ^4.0 so the fix should be something like in doctrine/DoctrineBundle#853, that's the reason why https://travis-ci.org/geocoder-php/BazingaGeocoderBundle/jobs/466503002 fails

@xkobal
Copy link
Contributor Author

xkobal commented Dec 18, 2018

@franmomu I have fixed my pull request as asked. it seems to work this time.

@Nyholm
Copy link
Member

Nyholm commented Dec 18, 2018

It looks like there is one more deprecation. Could you check that?

@xkobal
Copy link
Contributor Author

xkobal commented Dec 19, 2018

The deprecation come from the PhpUnit version used on the test: 5.7.27.
On my computer, when I composer install (without flags) I have the 6.5.13 and I have no deprecation.

So I don't know how to upgrade the phpunit version. Seems to come from the composer flag passed in travis.yml (--prefer-stable --prefer-lowest --prefer-dist).

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit f1435e8 into geocoder-php:master Dec 22, 2018
@xkobal xkobal deleted the patch-2 branch January 2, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants