ci: fix linting

include typescript, add some rules. Some of them should be enabled later.

.eslintrc.js

@@ -1,9 +1,17 @@
 module.exports = {
+    root: true,
+    parser: "@typescript-eslint/parser",
+    plugins: ["@typescript-eslint"],
     env: {
         browser: true,
         es6: true,
     },
-    extends: ["eslint:recommended", "prettier"],
+    extends: [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/eslint-recommended",
+        "plugin:@typescript-eslint/recommended",
+        "prettier",
+    ],
     parserOptions: {
         ecmaVersion: 2022,
         sourceType: "module",
@@ -20,5 +28,9 @@ module.exports = {
         "dot-notation": "off",
         "no-unused-vars": ["error", { args: "none" }],
         "require-await": "off",
+        "@typescript-eslint/no-unused-vars": "off",
+        "@typescript-eslint/ban-ts-comment": "off",
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-this-alias": "off",
     },
 };

package.json

@@ -8,8 +8,10 @@
     "@commitlint/cli": "^16.2.4",
     "@commitlint/config-conventional": "^16.2.4",
     "@rollup/plugin-replace": "^5.0.0",
+    "@typescript-eslint/eslint-plugin": "^7.8.0",
+    "@typescript-eslint/parser": "^7.8.0",
     "dependency-cruiser": "^15.3.0",
-    "eslint": "^8.23.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "express": "^4.17.2",
     "husky": "^8.0.1",

packages/app/src/utils/crc32.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 /* eslint-disable global-require */
 /*
  * Adapted from: https://stackoverflow.com/a/18639999/1547896

packages/core/src/spec/axis.d.ts

@@ -135,9 +135,7 @@ export interface Axis extends BaseAxis {
 
 export interface BaseAxis<
     N = number,
-    NS = number,
     B = boolean,
-    BNS = number | boolean,
     S = string,
     C = string,
     FW = string,

packages/core/src/spec/scale.d.ts

@@ -130,7 +130,7 @@ export interface Scale {
     round?: boolean;
 
     /**
-     * For _[continuous](https://vega.github.io/vega-lite/docs/scale.html#continuous)_ scales, expands the scale domain to accommodate the specified number of pixels on each of the scale range. The scale range must represent pixels for this parameter to function as intended. Padding adjustment is performed prior to all other adjustments, including the effects of the `zero`, `nice`, `domainMin`, and `domainMax` properties.
+     * For _[continuous](https://vega.github.io/vega-lite/docs/scale.html#continuous)_ scales, expands the scale domain to accommodate the specified number of pixels on each of the scale range. The scale range must represent pixels for this parameter to function as intended. Padding adjustment is performed prior to all other adjustments, including the effects of the `zero`, `nice`, `domainMin`, and `domainMax` properties.
      *
      * For _[band](https://vega.github.io/vega-lite/docs/scale.html#band)_ scales, shortcut for setting `paddingInner` and `paddingOuter` to the same value.
      *