Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop from 1.30.1 to 1.31.0 #445

Merged
merged 1 commit into from Jun 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
Expand Up @@ -78,7 +78,7 @@ jobs:
ruby-version: 3.1.2
- name: Run RuboCop
run: |
bundle add rubocop --version 1.30.1
bundle add rubocop --version 1.31.0
bundle add rubocop-minitest --version 0.20.1
bundle add rubocop-rake --version 0.6.0
bundle exec rubocop
7 changes: 7 additions & 0 deletions .rubocop.yml
Expand Up @@ -5,6 +5,12 @@ AllCops:
NewCops: enable
SuggestExtensions: false

# Disabling this cop at this moment
# https://github.com/rubocop/rubocop/pull/10696
Lint/NonAtomicFileOperation:
Enabled: false

# The following is a workaround for disorder in rubocop auto-gen-config
Layout/SpaceBeforeBlockBraces:
Exclude:
- 'lib/geminabox_client.rb'
Expand All @@ -22,3 +28,4 @@ Layout/SpaceBeforeBlockBraces:
Naming/MethodName:
Exclude:
- 'test/units/geminabox/server_test.rb'
# DO NOT ADD BELOW THIS SECTION
23 changes: 0 additions & 23 deletions .rubocop_todo.yml
Expand Up @@ -188,13 +188,6 @@ Layout/EmptyLinesAroundModuleBody:
- 'test/units/geminabox/disk_cache_test.rb'
- 'test/units/geminabox/rubygems_dependency_test.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
Layout/ExtraSpacing:
Exclude:
- 'geminabox.gemspec'
tnir marked this conversation as resolved.
Show resolved Hide resolved

# Offense count: 6
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: IndentationWidth.
Expand Down Expand Up @@ -514,14 +507,6 @@ Naming/RescuedExceptionsVariableName:
- 'test/units/geminabox/gem_store_error_test.rb'
- 'test/units/geminabox/gem_store_test.rb'

# Offense count: 3
# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
# SupportedStyles: snake_case, normalcase, non_integer
# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339
Naming/VariableNumber:
Exclude:
- 'lib/geminabox/indexer.rb'
tnir marked this conversation as resolved.
Show resolved Hide resolved

# Offense count: 1
Security/Eval:
Exclude:
Expand Down Expand Up @@ -590,14 +575,6 @@ Style/ColonMethodCall:
- 'lib/geminabox_client.rb'
- 'test/test_support/geminabox_test_case.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
# SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment:
Exclude:
- 'lib/geminabox/incoming_gem.rb'
tnir marked this conversation as resolved.
Show resolved Hide resolved

# Offense count: 26
# Configuration parameters: AllowedConstants.
Style/Documentation:
Expand Down