Fix Sanitization class to deal with null values #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nerijunior é possível add testes ao seu PR? Sua solução parece funcionar bem, mas seria muito bom ter teste garantindo sua contrib. |
|
vou adicionar! |
nerijunior
force-pushed
the
fix/sanitization-accepting-nulls
branch
from
f997f12
to
50bf298
Compare
|
@vicentimartins os testes estão feitos, o problema é que o CI não vai passar enquanto o PR #108 não foi aceito. |
|
@nerijunior muito bom Neri, obg por add o teste. O #108 vai atualizar a versão do PHP para a lib, então sua checagem vai passar tranquilamente. |
nerijunior
force-pushed
the
fix/sanitization-accepting-nulls
branch
from
50bf298
to
d57c8e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O título do PR é auto explicativo. Testando no Laravel 8 e recebendo o campo em branco, o
preg_replacefalha porque não é string|array e sim null.