Skip to content

Commit

Permalink
merge master
Browse files Browse the repository at this point in the history
  • Loading branch information
mperham committed Mar 1, 2019
2 parents 653c58f + edbefc4 commit 60bb816
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 16 deletions.
3 changes: 2 additions & 1 deletion test/test_launcher.rb
Expand Up @@ -92,7 +92,6 @@ def new_manager(opts)
assert_in_delta 60000, expires, 50
end
end
end

it 'fires new heartbeat events' do
i = 0
Expand Down Expand Up @@ -124,6 +123,7 @@ def new_manager(opts)
assert_in_delta 60000, expires, 500
end
end
end

describe 'when manager is stopped' do
before do
Expand Down Expand Up @@ -151,4 +151,5 @@ def new_manager(opts)
def options
{ :concurrency => 3, :queues => ['default'], :tag => 'myapp' }
end

end
38 changes: 23 additions & 15 deletions test/test_processor.rb
Expand Up @@ -333,25 +333,33 @@ def call(item, queue)
@mgr.expect(:options, {:queues => ['default'], job_logger: CustomJobLogger})
@processor = ::Sidekiq::Processor.new(@mgr)
end
end
end

describe 'when failed' do
let(:failed_today_key) { "stat:failed:#{Time.now.utc.strftime("%Y-%m-%d")}" }

def failed_job
msg = Sidekiq.dump_json({ 'class' => MockWorker.to_s, 'args' => ['boom'] })
begin
@processor.process(work(msg))
rescue TestProcessorException
end
end
describe 'stats' do
before do
Sidekiq.redis {|c| c.flushdb }
end

it 'increments failed stat' do
Sidekiq::Processor::FAILURE.reset
failed_job
assert_equal 1, Sidekiq::Processor::FAILURE.reset
end
def failed_job
msg = Sidekiq.dump_json({ 'class' => MockWorker.to_s, 'args' => ['boom'] })
begin
@processor.process(work(msg))
rescue TestProcessorException
end
end

def successful_job
msg = Sidekiq.dump_json({ 'class' => MockWorker.to_s, 'args' => ['myarg'] })
@mgr.expect(:processor_done, nil, [@processor])
@processor.process(work(msg))
end

it 'increments processed stat' do
Sidekiq::Processor::PROCESSED.reset
successful_job
assert_equal 1, Sidekiq::Processor::PROCESSED.reset
end
end

describe 'custom job logger class' do
Expand Down
4 changes: 4 additions & 0 deletions test/test_sidekiqctl.rb
Expand Up @@ -17,6 +17,10 @@ def output(section = 'all')
end

describe Sidekiq::Ctl do
before do
Sidekiq.redis {|c| c.flushdb}
end

describe 'status' do
describe 'version' do
it 'displays the current Sidekiq version' do
Expand Down

0 comments on commit 60bb816

Please sign in to comment.