hyperlinks: add support for optional id parameter #570
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSC8 escape sequences allow for marking up hyperlinks in the terminal. An optional `id` parameter is defined to allow applications to signal to the terminal that (potentially) broken character sequences belong to the same URL and should be treated as if they were connected. Add support for optional id parameters, set by the application. Update test case for ti.EnterUrl. Fixes: gdamore#568 Reference: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#hover-underlining-and-the-id-parameter
gdamore
approved these changes
Oct 15, 2022
Not needed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSC8 escape sequences allow for marking up hyperlinks in the terminal. An optional
idparameter is defined to allow applications to signal to the terminal that (potentially) broken character sequences belong to the same URL and should be treated as if they were connected.Add support for optional id parameters, set by the application. Update test case for ti.EnterUrl.
Fixes: #568
Reference: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#hover-underlining-and-the-id-parameter