Send a dummy input to clear the read block #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed gdamore#452. When switching nonBlocking, a dummy input is sent to process read and clear the read block.
|
There may be other ways to solve this problem. This is an idea. |
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
=========================================
Coverage ? 16.87%
=========================================
Files ? 20
Lines ? 1387
Branches ? 0
=========================================
Hits ? 234
Misses ? 1139
Partials ? 14
Continue to review full report at Codecov.
|
|
This turns out not to be necessary. Please see my "tty" branch for a likely solution. |
|
See #459 for my approach that I think sorts this. |
|
I've merged #459 into master which addresses this problem, and makes this PR obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #452.
When switching nonBlocking, a dummy input is sent to process read
and clear the read block.