Patch for mouse events not working when using applications from PuTTY terminal #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramachandrasuresh
changed the title
|
This looks good, just trying to find my documentation on what 1006 was used for. Stay tuned. |
|
Found it. Was looking at an older version of the escape sequences doc. (1006 is SGR mode.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
With tcell v2.2.0 and up, mouse events stopped working for PuTTY.
Solution:
When the MouseFlags are not set/present, default the flags to also Include the mouse drag and button events and loop through each mouse event.
Results w/ fix:
Mouse events work for PuTTY and other terminals.