Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang 14 to test suite #731

Merged
merged 5 commits into from Feb 24, 2023
Merged

Add clang 14 to test suite #731

merged 5 commits into from Feb 24, 2023

Conversation

Spacetown
Copy link
Member

Since XCode has updated from clang-13 to clang-14 I need to add this version to our test suite to be able to test faster.

@Spacetown Spacetown added Type: Enhancement QA related to testing, build infrastructure, etc labels Feb 23, 2023
@Spacetown Spacetown added this to the 6.0 milestone Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 95.57% // Head: 95.59% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f827099) compared to base (ea2f842).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
+ Coverage   95.57%   95.59%   +0.01%     
==========================================
  Files          28       28              
  Lines        3845     3855      +10     
  Branches      671      672       +1     
==========================================
+ Hits         3675     3685      +10     
  Misses         92       92              
  Partials       78       78              
Flag Coverage Δ
ubuntu-20.04 94.28% <ø> (+0.01%) ⬆️
windows-2019 95.18% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/tests/test_gcovr.py 97.64% <ø> (ø)
gcovr/configuration.py 99.69% <0.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

In the past the reference data was only build on the server. For the docker image the generation of diff.zip is not used anymore and therefore we do not need the chmod at all.
This is also improving the image startup time.
Copy link
Member

@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Not 100% sure about the changes to the Dockerfile, but I think the chown had become superfluous anyway.

@Spacetown
Copy link
Member Author

gtm. Not 100% sure about the changes to the Dockerfile, but I think the chown had become superfluous anyway.

Yes, it's not needed anymore because we don't generate a artifact anymore. Also the upload can be removed. The option to create the diff.zip was removed with the switch to nox in #516.

@Spacetown Spacetown merged commit b4595b3 into gcovr:master Feb 24, 2023
@Spacetown Spacetown deleted the add_clang_14 branch February 24, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA related to testing, build infrastructure, etc Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants