New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clang 14 to test suite #731
Conversation
Codecov ReportBase: 95.57% // Head: 95.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 95.57% 95.59% +0.01%
==========================================
Files 28 28
Lines 3845 3855 +10
Branches 671 672 +1
==========================================
+ Hits 3675 3685 +10
Misses 92 92
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
In the past the reference data was only build on the server. For the docker image the generation of diff.zip is not used anymore and therefore we do not need the chmod at all. This is also improving the image startup time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Not 100% sure about the changes to the Dockerfile, but I think the chown had become superfluous anyway.
Yes, it's not needed anymore because we don't generate a artifact anymore. Also the upload can be removed. The option to create the diff.zip was removed with the switch to nox in #516. |
Since XCode has updated from
clang-13
toclang-14
I need to add this version to our test suite to be able to test faster.