Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing properties correctly #435

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Handle missing properties correctly #435

wants to merge 8 commits into from

Commits on Apr 1, 2020

  1. gcanti#434 Handle missing properties correctly 

    A property can only be missing if the property is optional.
Properties with types that accept undefined values must
always be present unless they are optional properties.
    @leilapearson
    leilapearson committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    5914804 View commit details
    Browse the repository at this point in the history

  2. Add decode success tests and improve test names

    @leilapearson
    leilapearson committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    1dcf96f View commit details
    Browse the repository at this point in the history

  3. Refactor recursion tests to separate assertions 

    Also remove some `type` tests that are redundant
since the following are equivalent:

- `null` and `nullType`
- `void` and `voidType`
- `strict` and  `exact`
    @leilapearson
    leilapearson committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    2a547a7 View commit details
    Browse the repository at this point in the history

  4. Fix prettier

    @leilapearson
    leilapearson committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    c595713 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Add missing properties tests for strict

    @leilapearson
    leilapearson committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    503878b View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2020

  1. Merge branch 'master' into handle-missing-properties-correctly

    @leilapearson
    leilapearson committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    5fe66f6 View commit details
    Browse the repository at this point in the history

  2. fix prettier

    @leilapearson
    leilapearson committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    ec362cf View commit details
    Browse the repository at this point in the history

  3. improve test error messages

    @leilapearson
    leilapearson committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    add3c2b View commit details
    Browse the repository at this point in the history