add Tree.findDepthFirst and Tree.findBreadthFirst and Tree.filter

[thekemlin]

Add some utility functions to Tree module.

[thekemlin]

Hi @gcanti !
I put lots of effort into the PR I submitted and I would really appreciate it if you can take a look and give me some suggestions on the code if you have any. Thanks!

[kalda341]

This would be really helpful for me too.

One thing to consider would be whether the find and filter should be operating on the tree itself, or the value contained.
I think your approach (the tree itself) is the better one as it is more flexible (and similar to operations I've built). Maybe it's worth implementing both (findNodeDepthFirst, findDepthFirst, or similar naming convention)?

When it comes to filter (which is really useful to me), it would probably be worth having both a depth first and breadth first option if we're operating on the tree, as when filtering an element your predicate may care about how many filtered children remain, for example.

What do you think? I'm happy to help get this across the line.

[thekemlin]

Maybe it's worth implementing both (findNodeDepthFirst, findDepthFirst, or similar naming convention)?

Yes, It's valuable.

When it comes to filter (which is really useful to me), it would probably be worth having both a depth first and breadth first option.

I am confused.
Are you mean:
When filter on a tree, there should be two ways to traverse the tree:

1. Apply the predicate to the forest of the node, and then the node's own value.
2. Apply the predicate to the node's own value, if the result is true, then filter the forest of the node recursively. (current implementation)

[kalda341]

@polymona Yes, that's what I mean :)

[thekemlin]

@gcanti What do you think? Is it worth to add those functions to fp-ts?