Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address WithBalancerName deleted in grpc v1.46.0 #324

Merged
merged 2 commits into from Jun 15, 2022

Conversation

apesternikov
Copy link
Contributor

@apesternikov apesternikov commented Jun 9, 2022

address deleted WithBalancerName that was deprecated for 2 years.
See for context:
https://github.com/grpc/grpc-go/releases/tag/v1.46.0
grpc/grpc-go#5232


This change is Reviewable

@apesternikov apesternikov changed the title upgrade grpc to v1.47.0 address WithBalancerName deleted in grpc to v1.46.0 Jun 9, 2022
@apesternikov apesternikov changed the title address WithBalancerName deleted in grpc to v1.46.0 address WithBalancerName deleted in grpc v1.46.0 Jun 9, 2022
Copy link
Collaborator

@michaelschiff michaelschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@psFried psFried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the contribution!

@psFried psFried merged commit 0213e03 into gazette:master Jun 15, 2022
michaelschiff pushed a commit to michaelschiff/core that referenced this pull request Jun 16, 2022
* upgrade grpc to v1.47.0 & address deleted WithBalancerName that was deprecated for 2 years grpc/grpc-go#5232

* restore go.mod and go.sum
michaelschiff pushed a commit to michaelschiff/core that referenced this pull request Jun 16, 2022
* upgrade grpc to v1.47.0 & address deleted WithBalancerName that was deprecated for 2 years grpc/grpc-go#5232

* restore go.mod and go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants