Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jammy to not use gcc-8 #54

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Update jammy to not use gcc-8 #54

merged 2 commits into from
Apr 7, 2022

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Apr 6, 2022

Copy of #50 targeting jammy. This is needed to fix Jammy CI:

Depends on #53

scpeters and others added 2 commits April 6, 2022 13:52
@scpeters
Try checking out ci_matching_branch for gzdev (#46)
df2395b 
Code copied from release-tools#572

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@mjcarroll @scpeters
Update focal to use gcc9
04e58ae 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
mjcarroll approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a note that jammy will be gcc-11, if I recall correctly.

@scpeters scpeters changed the title Update focal to use gcc9 Update jammy to not use gcc-8 Apr 6, 2022
@scpeters
Copy link
Contributor Author

scpeters commented Apr 6, 2022

LGTM. Just a note that jammy will be gcc-11, if I recall correctly.

I updated the PR title accordingly

Base automatically changed from pick_ci_matching_branch_jammy to jammy April 6, 2022 22:43
@chapulina
Copy link
Contributor

Same thing as #50, can we trigger a build that has coverage enabled and uses this branch?

@chapulina
Copy link
Contributor

We don't have coverage running for any libs on Jammy yet, I believe, so let's deal with that later

@chapulina chapulina merged commit e82e1b4 into jammy Apr 7, 2022
@chapulina chapulina deleted the jammy_gcc9 branch April 7, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scpeters @chapulina @mjcarroll