Unify method naming #252 #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks, but that issue was not actually marked as help-wanted (and is already assigned). These renames will be done slowly during several releases, to give users time to update. Also, as described in the issue, renames will be done via adding a new method and deprecating the old one. Just renaming a method, as you did here, will break compatibility. |
|
@gavv Apologies I wasn't aware of it. Do we have a contributing docs for the repo Where I can understand the process for contribution/ |
|
Yes, see "Contributing" section in README. It points to "HACKING.md", which has "Working on a task" section. General hints for any github repo are:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed few methods in Match, Cookie.
Hey @gavv please review the code changes