Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow check-modified-files-only to be used in combination with file-extension #43

Closed
Andarist opened this issue Jun 5, 2020 · 2 comments · Fixed by #47
Closed

Allow check-modified-files-only to be used in combination with file-extension #43

Andarist opened this issue Jun 5, 2020 · 2 comments · Fixed by #47

Comments

@Andarist
Copy link

Andarist commented Jun 5, 2020

As far as I can tell this:

for i in "${FILE_ARRAY[@]}"
do
if [ ${i: -3} = ".md" ]; then
FIND_CALL+=("${i}")
COMMAND="${FIND_CALL[@]}"
$COMMAND &>> error.txt || true
unset 'FIND_CALL[${#FIND_CALL[@]}-1]'
fi
done

is ignoring file-extension option altogether.

I would prepare a PR adding this functionality, but unfortunately, bash scripting is not my strongest suit. If nobody picks it up I might come back to take a stab at implementing this but this might take some time before I get to it.

@Andarist
Copy link
Author

Andarist commented Jun 6, 2020

@gaurav-nelson thank you for implementing this! much appreciated ❤️

@gaurav-nelson
Copy link
Owner

Thanks @Andarist I'll mark it as release soon. Thanks for identifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants