check-modified-files-only filtering files incorrectly

[Andarist]

Followup to #43

This always compares against the last 3 characters whereas it should compare against the length of FILE_EXTENSION:

github-action-markdown-link-check/entrypoint.sh

Line 84 in ee0afb2

if [ ${i: -3} = "${FILE_EXTENSION}" ]; then

[gaurav-nelson]

🤦‍♂️

[gaurav-nelson]

@Andarist Can you please check it with the commit ID using:

 uses: gaurav-nelson/github-action-markdown-link-check@0eb8a0e

Want to confirm that the fix works before releasing it this time 😉

[gaurav-nelson]

Also I see a couple of PRs in the repository at https://github.com/livechat/livechat-public-docs
I'd love to see it work on Gatsby sites by don't yet figured out how to deal with slugs that don't always represent full file path.

[Andarist]

Want to confirm that the fix works before releasing it this time 😉

I'm afraid it doesn't work 😅
https://github.com/livechat/livechat-public-docs/runs/753428367#step:4:16
There seems to be a syntax problem here:

github-action-markdown-link-check/entrypoint.sh

Line 21 in 0eb8a0e

if [ "$8" -eq 0 ]; then

I'd love to see it work on Gatsby sites by don't yet figured out how to deal with slugs that don't always represent full file path.

Hm, I was just trying to help out our content writer and I'm not involved in this project (I don't know how exactly it's set up with Gatsby etc) as I'm from the other team. I'm not sure when this could potentially affect them - ideally they should aim for 1 to 1 mapping between .mdx and the generated site so checking the correctness of in-repo links should pretty much guarantee that they would stay correct after compiling the site. But maybe this cannot be guaranteed at all times - I'm not sure.

[gaurav-nelson]

@Andarist Can you please check it again using

uses: gaurav-nelson/github-action-markdown-link-check@619e549

I think this will work.

[Andarist]

It doesn't crash, but doesn't work as expected. It has reported that all links are good here: https://github.com/livechat/livechat-public-docs/runs/775941325?check_suite_focus=true#step:4:29

whereas when running:

markdown-link-check ./content/management/configuration-api/v2.0/index.mdx

I get a report about 7 dead links

[gaurav-nelson]

Closing this one as well. #64 fixes this. Now it compares all file extension

if [ "${i##*.}" == "${FILE_EXTENSION#.}" ]; then