forked from checkstyle/checkstyle
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Issue checkstyle#7754: Update AbstractChecks to log DetailAST - OneTo…
…pLevelClass
- Loading branch information
Showing
10 changed files
with
148 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionOneTopLevelClassTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| //////////////////////////////////////////////////////////////////////////////// | ||
| // checkstyle: Checks Java source code for adherence to a set of rules. | ||
| // Copyright (C) 2001-2020 the original author or authors. | ||
| // | ||
| // This library is free software; you can redistribute it and/or | ||
| // modify it under the terms of the GNU Lesser General Public | ||
| // License as published by the Free Software Foundation; either | ||
| // version 2.1 of the License, or (at your option) any later version. | ||
| // | ||
| // This library is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| // Lesser General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU Lesser General Public | ||
| // License along with this library; if not, write to the Free Software | ||
| // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | ||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| package org.checkstyle.suppressionxpathfilter; | ||
|
|
||
| import java.io.File; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import com.puppycrawl.tools.checkstyle.DefaultConfiguration; | ||
| import com.puppycrawl.tools.checkstyle.checks.design.OneTopLevelClassCheck; | ||
|
|
||
| public class XpathRegressionOneTopLevelClassTest extends AbstractXpathTestSupport { | ||
|
|
||
| private final String checkName = OneTopLevelClassCheck.class.getSimpleName(); | ||
|
|
||
| @Override | ||
| protected String getCheckName() { | ||
| return checkName; | ||
| } | ||
|
|
||
| @Test | ||
| public void testOne() throws Exception { | ||
| final File fileToProcess = | ||
| new File(getPath("SuppressionXpathRegressionOneTopLevelClass.java")); | ||
|
|
||
| final DefaultConfiguration moduleConfig = | ||
| createModuleConfig(OneTopLevelClassCheck.class); | ||
|
|
||
| final String[] expectedViolation = { | ||
| "7:1: " + getCheckMessage(OneTopLevelClassCheck.class, | ||
| OneTopLevelClassCheck.MSG_KEY, "ViolatingSecondClass"), | ||
| }; | ||
|
|
||
| final List<String> expectedXpathQueries = Arrays.asList( | ||
| "/CLASS_DEF[./IDENT[@text='ViolatingSecondClass']]", | ||
| "/CLASS_DEF[./IDENT[@text='ViolatingSecondClass']]/MODIFIERS", | ||
| "/CLASS_DEF[./IDENT[@text='ViolatingSecondClass']]/LITERAL_CLASS" | ||
| ); | ||
|
|
||
| runVerifications(moduleConfig, fileToProcess, expectedViolation, | ||
| expectedXpathQueries); | ||
| } | ||
| } |
9 changes: 9 additions & 0 deletions
9
...e/suppressionxpathfilter/onetoplevelclass/SuppressionXpathRegressionOneTopLevelClass.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package org.checkstyle.suppressionxpathfilter.onetoplevelclass; | ||
|
|
||
| public class SuppressionXpathRegressionOneTopLevelClass { | ||
| // methods | ||
| } | ||
|
|
||
| class ViolatingSecondClass { //warn | ||
| // methods | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -140,9 +140,6 @@ | |
| * NoLineWrap | ||
| * </li> | ||
| * <li> | ||
| * OneTopLevelClass | ||
| * </li> | ||
| * <li> | ||
| * OuterTypeFilename | ||
| * </li> | ||
| * <li> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
...awl/tools/checkstyle/checks/design/onetoplevelclass/InputOneTopLevelClassIndentation.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package com.puppycrawl.tools.checkstyle.checks.design.onetoplevelclass; | ||
|
|
||
| public class InputOneTopLevelClassIndentation { | ||
| // methods | ||
| } | ||
|
|
||
| class ViolatingIndentedClass1 { | ||
| // methods | ||
| } | ||
|
|
||
| class ViolatingIndentedClass2 { | ||
| // methods | ||
| } | ||
|
|
||
| interface ViolatingNonIndentedInterface { | ||
| // methods | ||
| } |
3 changes: 3 additions & 0 deletions
3
...ycrawl/tools/checkstyle/checks/design/onetoplevelclass/InputOneTopLevelClassSameLine.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| package com.puppycrawl.tools.checkstyle.checks.design.onetoplevelclass; | ||
|
|
||
| public class InputOneTopLevelClassSameLine {} enum ViolatingSecondType {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters