Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-graphiql-explorer): lower minimum node version #38577

Merged
merged 1 commit into from Sep 26, 2023

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Sep 26, 2023

Description

#36560 and #36796 bumped min node version for all packages in preperation for gatsby v5 release with understanding that all those packages would only be used with Gatsby. gatsby-graphiql-explorer can be used as standalone so this looks to lower its min node version requierment. Code itself is compatible with older node so this should be just matter of adjusting package.json engine.

Documentation

Tests

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 26, 2023
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 26, 2023
@pieh pieh changed the title feat(gatsby-graphiql-explorer): lower minimun node version feat(gatsby-graphiql-explorer): lower minimum node version Sep 26, 2023
@pieh pieh marked this pull request as ready for review September 26, 2023 14:31
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pieh pieh merged commit 9a2e746 into master Sep 26, 2023
33 checks passed
@pieh pieh deleted the feat/relax-gatsby-graphiql-min-node-version branch September 26, 2023 15:05
@pieh pieh added this to To cherry-pick in V5 Release hotfixes via automation Sep 26, 2023
pieh added a commit that referenced this pull request Sep 26, 2023
feat(gatsby-graphiql-explorer): lower minimun node version

(cherry picked from commit 9a2e746)
@pieh pieh moved this from To cherry-pick to Backport PR opened in V5 Release hotfixes Sep 26, 2023
pieh added a commit that referenced this pull request Sep 27, 2023
…38579)

feat(gatsby-graphiql-explorer): lower minimun node version

(cherry picked from commit 9a2e746)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@pieh pieh moved this from Backport PR opened to Backported in V5 Release hotfixes Sep 27, 2023
@pieh pieh moved this from Backported to Published in V5 Release hotfixes Oct 3, 2023
This was referenced Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants