Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Pin @babel/plugin-transform-modules-commonjs to 7.18.6 #37660

Merged
merged 6 commits into from Feb 16, 2023

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Feb 15, 2023

Description

Reverts bump of @babel/plugin-transform-modules-commonjs which happened in #37386 as it contained babel/babel#15290 which changes the transpiled output of await import statements, making it incompatible with our engines (bundled through webpack). This was surfaced through #37632

Added a E2E test for contentful (since it uses a dynamic import) to not regress on this again.

Related Issues

Fixes #37632

@LekoArts LekoArts added topic: source-contentful Related to Gatsby's integration with Contentful topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) labels Feb 15, 2023
@LekoArts LekoArts added this to To cherry-pick in V5 Release hotfixes via automation Feb 15, 2023
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 15, 2023
@LekoArts LekoArts changed the title revert dep changes fix(gatsby-source-contentful): Revert babel upgrade Feb 15, 2023
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 15, 2023
pieh
pieh previously approved these changes Feb 15, 2023
@LekoArts LekoArts changed the title fix(gatsby-source-contentful): Revert babel upgrade fix(deps): Revert #37568 Feb 15, 2023
@LekoArts LekoArts changed the title fix(deps): Revert #37568 fix(deps): Pin @babel/plugin-transform-modules-commonjs to 7.20.7 Feb 15, 2023
wardpeet
wardpeet previously approved these changes Feb 15, 2023
@pieh pieh changed the title fix(deps): Pin @babel/plugin-transform-modules-commonjs to 7.20.7 fix(deps): Pin @babel/plugin-transform-modules-commonjs to 7.18.6 Feb 15, 2023
@LekoArts LekoArts merged commit 389b100 into master Feb 16, 2023
@LekoArts LekoArts deleted the fix-37632 branch February 16, 2023 07:13
LekoArts added a commit that referenced this pull request Feb 16, 2023
…37660)

Co-authored-by: pieh <misiek.piechowiak@gmail.com>
(cherry picked from commit 389b100)
@LekoArts LekoArts moved this from To cherry-pick to Backport PR opened in V5 Release hotfixes Feb 16, 2023
LekoArts added a commit that referenced this pull request Feb 16, 2023
…37660) (#37665)

Co-authored-by: pieh <misiek.piechowiak@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
@LekoArts LekoArts moved this from Backport PR opened to Published in V5 Release hotfixes Feb 16, 2023
@LekoArts
Copy link
Contributor Author

Published in gatsby-source-contentful@8.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-contentful Related to Gatsby's integration with Contentful topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem)
Projects
Development

Successfully merging this pull request may close these issues.

Build fails when I have an SSR page and gatsby-source-contentful working together
3 participants