fix(gatsby-plugin-preact): Adjust framework chunk overwrite #37658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
topic: plugins
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
LekoArts
commented
Feb 15, 2023
| @@ -121,7 +138,7 @@ describe(`gatsby-plugin-preact`, () => { | |||
| "enforce": true, | |||
| "name": "framework", | |||
| "priority": 40, | |||
| "test": [Function], | |||
| "test": /\\(\\?<!node_modules\\.\\*\\)\\[\\\\\\\\/\\]node_modules\\[\\\\\\\\/\\]\\(preact\\|react\\|react-dom\\|scheduler\\|prop-types\\)\\[\\\\\\\\/\\]/, | |||
There was a problem hiding this comment.
Previously this was the function:
module =>
/(?<!node_modules.*)[\\/]node_modules[\\/](preact)[\\/]/.test(
module.resource
)
LekoArts
commented
Feb 15, 2023
| @@ -141,7 +158,7 @@ describe(`gatsby-plugin-preact`, () => { | |||
| "enforce": true, | |||
| "name": "framework", | |||
| "priority": 40, | |||
| "test": /\\(\\?<!node_modules\\.\\*\\)\\[\\\\\\\\/\\]node_modules\\[\\\\\\\\/\\]\\(react\\|react-dom\\|scheduler\\|prop-types\\)\\[\\\\\\\\/\\]/, | |||
| "test": [Function], | |||
There was a problem hiding this comment.
Previously this was the regex in the mock above
LekoArts
commented
Feb 15, 2023
| @@ -1,5 +1,20 @@ | |||
| const PreactRefreshPlugin = require(`@prefresh/webpack`) | |||
|
|
|||
| const FRAMEWORK_BUNDLES_PREACT = [ | |||
| `preact`, | |||
There was a problem hiding this comment.
Main change: Adding preact to this regex and then just using this regex instead of trying to reuse what Gatsby framework itself uses
pieh
approved these changes
Feb 15, 2023
|
Man, you are using statoscope, this is soo awesome! Didn't realize that. cc @smelukov |
LekoArts
added a commit
that referenced
this pull request
Feb 16, 2023
(cherry picked from commit d47ef5e)
|
Yeah, great tool! I use it through https://github.com/LekoArts/gatsby-plugin-webpack-statoscope |
LekoArts
added a commit
that referenced
this pull request
Feb 16, 2023
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #37508 our internals for the
frameworkchunk changed. I decided to not do the optimization forreact-dom/serveryet as we haven't heard complaints about that in combination with Preact and its compat layer also works different so I'm not convinced that this is even needed. We could change it at a later stage, for now I just wanted to fix the test itself.Testing
Used
gatsby-plugin-preactin a test site, chunking seems correct:Related Issues
Fixes #37653