Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-sharp): read plugin options during report error #37165

Closed
wants to merge 2 commits into from
Closed

feat(gatsby-plugin-sharp): read plugin options during report error #37165

wants to merge 2 commits into from

Conversation

Jeff-Tian
Copy link

…yjs/gatsby/discussions/37151

Description

Respect plugin option's failOnError option during reporting errors, don't exit rudely.

Documentation

Related Issues

Fix #37151

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 3, 2022
@Jeff-Tian Jeff-Tian changed the title feat: read plugin options during report error feat(gatsby-plugin-sharp): read plugin options during report error Dec 3, 2022
@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 5, 2022
@LekoArts
Copy link
Contributor

LekoArts commented Dec 5, 2022

Hi, thanks for the PR! This isn't the correct fix for this though, I put up a PR that should make failOn work correctly: #37177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants