Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Remove LOCKED_IN feature flags #36810

Merged
merged 15 commits into from
Oct 18, 2022
Merged

chore(gatsby): Remove LOCKED_IN feature flags #36810

merged 15 commits into from
Oct 18, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Oct 13, 2022 •
edited

Description

Removes LOCKED_IN feature flags.

  • remove PRESERVE_WEBPACK_CACHE
  • remove DEV_WEBPACK_CACHE
  • remove LAZY_IMAGES
  • remove LMDB_STORE
  • remove PARALLEL_QUERY_RUNNING
  • remove GRAPHQL_TYPEGEN
  • remove QUERY_ON_DEMAND

Documentation

No update needed since this is all internal. Only thing we could document is the new env var to enable QoD in CI (in the migration guide or something)

Related Issues

[ch55428]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 13, 2022
@LekoArts LekoArts added this to the Gatsby 5 milestone Oct 13, 2022
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 13, 2022
@LekoArts LekoArts marked this pull request as ready for review October 13, 2022 13:30
pieh
pieh approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@LekoArts LekoArts merged commit dc82d92 into master Oct 18, 2022
@LekoArts LekoArts deleted the remove-locked-in branch October 18, 2022 12:32
@pieh pieh mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyhopp tyhopp tyhopp left review comments

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Milestone
Gatsby 5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LekoArts @pieh @tyhopp