chore(packages): make unstable_shouldOnCreateNode stable

benchmarks/gabe-csv-markdown/gatsby-node.js

@@ -42,7 +42,7 @@ exports.createPages = async ({ graphql, actions }) => {
   })
 }
 
-exports.unstable_shouldOnCreateNode = ({ node }) =>
+exports.shouldOnCreateNode = ({ node }) =>
   node.internal.type === `GendataCsv`
 
 // Not sure if there is a better way than to create a proxy node for markdown to pick up

benchmarks/gabe-fs-text/gatsby-node.js

@@ -40,7 +40,7 @@ exports.createPages = async ({ graphql, actions }) => {
   })
 }
 
-exports.unstable_shouldOnCreateNode = ({ node }) =>
+exports.shouldOnCreateNode = ({ node }) =>
   node.internal.type === "File"
 
 exports.onCreateNode = ({ node, actions, createNodeId }) => {

packages/gatsby-plugin-mdx/src/gatsby-node.ts

@@ -282,11 +282,13 @@ export const createSchemaCustomization: GatsbyNode["createSchemaCustomization"]
   }
 
 // eslint-disable-next-line @typescript-eslint/naming-convention
-export const unstable_shouldOnCreateNode: GatsbyNode["unstable_shouldOnCreateNode"] =
-  ({ node }: { node: FileSystemNode }, pluginOptions) => {
-    const { extensions } = defaultOptions(pluginOptions)
-    return node.internal.type === `File` && extensions.includes(node.ext)
-  }
+export const shouldOnCreateNode: GatsbyNode["shouldOnCreateNode"] = (
+  { node }: { node: FileSystemNode },
+  pluginOptions
+) => {
+  const { extensions } = defaultOptions(pluginOptions)
+  return node.internal.type === `File` && extensions.includes(node.ext)
+}
 
 /**
  * Create Mdx nodes from MDX files.

packages/gatsby-transformer-asciidoc/src/gatsby-node.js

@@ -1,7 +1,7 @@
 const asciidoc = require(`asciidoctor`)()
 const _ = require(`lodash`)
 
-function unstable_shouldOnCreateNode({ node }, pluginOptions = {}) {
+function shouldOnCreateNode({ node }, pluginOptions = {}) {
   const extensionsConfig = pluginOptions.fileExtensions
 
   // make extensions configurable and use adoc and asciidoc as default
@@ -23,7 +23,7 @@ async function onCreateNode(
   },
   pluginOptions
 ) {
-  if (!unstable_shouldOnCreateNode({ node }, pluginOptions)) {
+  if (!shouldOnCreateNode({ node }, pluginOptions)) {
     return
   }
 
@@ -140,5 +140,5 @@ const extractPageAttributes = allAttributes =>
     return pageAttributes
   }, {})
 
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.onCreateNode = onCreateNode

packages/gatsby-transformer-csv/src/gatsby-node.js

@@ -8,7 +8,7 @@ const convertToJson = (data, options) =>
     .fromString(data)
     .then(jsonData => jsonData, new Error(`CSV to JSON conversion failed!`))
 
-function unstable_shouldOnCreateNode({ node }, pluginOptions = {}) {
+function shouldOnCreateNode({ node }, pluginOptions = {}) {
   const { extension } = node
   const { extensions } = pluginOptions
 
@@ -19,7 +19,7 @@ async function onCreateNode(
   { node, actions, loadNodeContent, createNodeId, createContentDigest },
   pluginOptions
 ) {
-  if (!unstable_shouldOnCreateNode({ node }, pluginOptions)) {
+  if (!shouldOnCreateNode({ node }, pluginOptions)) {
     return
   }
 
@@ -84,5 +84,5 @@ async function onCreateNode(
   return
 }
 
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.onCreateNode = onCreateNode

packages/gatsby-transformer-documentationjs/src/gatsby-node.js

@@ -185,7 +185,7 @@ exports.createResolvers = ({ createResolvers }) => {
   })
 }
 
-function unstable_shouldOnCreateNode({ node }) {
+function shouldOnCreateNode({ node }) {
   return (
     node.internal.type === `File` &&
     (node.internal.mediaType === `application/javascript` ||
@@ -195,14 +195,14 @@ function unstable_shouldOnCreateNode({ node }) {
   )
 }
 
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 
 /**
  * Implement the onCreateNode API to create documentation.js nodes
  * @param {Object} super this is a super param
  */
 exports.onCreateNode = async ({ node, actions, ...helpers }) => {
-  if (!unstable_shouldOnCreateNode({ node })) {
+  if (!shouldOnCreateNode({ node })) {
     return null
   }
 

packages/gatsby-transformer-excel/src/gatsby-node.js

@@ -28,15 +28,15 @@ const extensions = [
   `numbers`,
 ]
 
-function unstable_shouldOnCreateNode({ node }) {
+function shouldOnCreateNode({ node }) {
   return extensions.includes((node.extension || ``).toLowerCase())
 }
 
 async function onCreateNode(
   { node, actions, loadNodeContent, createNodeId, createContentDigest },
   options = {}
 ) {
-  if (!unstable_shouldOnCreateNode({ node })) {
+  if (!shouldOnCreateNode({ node })) {
     return
   }
 
@@ -108,5 +108,5 @@ async function onCreateNode(
   return
 }
 
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.onCreateNode = onCreateNode

packages/gatsby-transformer-hjson/src/gatsby-node.js

@@ -2,7 +2,7 @@ const _ = require(`lodash`)
 const path = require(`path`)
 const HJSON = require(`hjson`)
 
-function unstable_shouldOnCreateNode({ node }) {
+function shouldOnCreateNode({ node }) {
   // We only care about HJSON content.
   // NOTE the mime package does not recognize HJSON yet
   // See RFC https://hjson.org/rfc.html#rfc.section.1.3
@@ -19,7 +19,7 @@ async function onCreateNode({
   createNodeId,
   createContentDigest,
 }) {
-  if (!unstable_shouldOnCreateNode({ node })) {
+  if (!shouldOnCreateNode({ node })) {
     return
   }
 
@@ -63,5 +63,5 @@ async function onCreateNode({
   }
 }
 
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.onCreateNode = onCreateNode

packages/gatsby-transformer-javascript-frontmatter/src/gatsby-node.js

@@ -4,7 +4,7 @@ const traverse = require(`@babel/traverse`).default
 
 const fileExtsToProcess = [`js`, `jsx`, `ts`, `tsx`]
 
-function unstable_shouldOnCreateNode({ node }) {
+function shouldOnCreateNode({ node }) {
   // This only processes JavaScript and TypeScript files.
   return fileExtsToProcess.includes(node.extension)
 }
@@ -15,7 +15,7 @@ async function onCreateNode({
   loadNodeContent,
   createContentDigest,
 }) {
-  if (!unstable_shouldOnCreateNode({ node })) {
+  if (!shouldOnCreateNode({ node })) {
     return
   }
 
@@ -142,5 +142,5 @@ async function onCreateNode({
   }
 }
 
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.onCreateNode = onCreateNode

packages/gatsby-transformer-javascript-static-exports/src/gatsby-node.js

@@ -2,7 +2,7 @@ const _ = require(`lodash`)
 const babylon = require(`@babel/parser`)
 const traverse = require(`@babel/traverse`).default
 
-function unstable_shouldOnCreateNode({ node }) {
+function shouldOnCreateNode({ node }) {
   // This only processes JavaScript files.
   return node.internal.mediaType === `application/javascript`
 }
@@ -15,7 +15,7 @@ async function onCreateNode({
   createNodeId,
   createContentDigest,
 }) {
-  if (!unstable_shouldOnCreateNode({ node })) {
+  if (!shouldOnCreateNode({ node })) {
     return
   }
 
@@ -155,5 +155,5 @@ async function onCreateNode({
   }
 }
 
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.onCreateNode = onCreateNode

packages/gatsby-transformer-json/src/gatsby-node.js

@@ -1,7 +1,7 @@
 const _ = require(`lodash`)
 const path = require(`path`)
 
-function unstable_shouldOnCreateNode({ node }) {
+function shouldOnCreateNode({ node }) {
   // We only care about JSON content.
   return node.internal.mediaType === `application/json`
 }
@@ -10,7 +10,7 @@ async function onCreateNode(
   { node, actions, loadNodeContent, createNodeId, createContentDigest },
   pluginOptions
 ) {
-  if (!unstable_shouldOnCreateNode({ node })) {
+  if (!shouldOnCreateNode({ node })) {
     return
   }
 
@@ -78,5 +78,5 @@ async function onCreateNode(
   }
 }
 
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.onCreateNode = onCreateNode

packages/gatsby-transformer-pdf/src/gatsby-node.js

@@ -2,7 +2,7 @@
 const Promise = require(`bluebird`)
 const PDFParser = require(`pdf2json`)
 
-function unstable_shouldOnCreateNode({ node }) {
+function shouldOnCreateNode({ node }) {
   // Filter out non-pdf content
   return node.extension === `pdf`
 }
@@ -27,7 +27,7 @@ async function onCreateNode({
   createNodeId,
   createContentDigest,
 }) {
-  if (!unstable_shouldOnCreateNode({ node })) {
+  if (!shouldOnCreateNode({ node })) {
     return
   }
 
@@ -51,5 +51,5 @@ async function onCreateNode({
   createParentChildLink({ parent: node, child: pdfNode })
 }
 
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.onCreateNode = onCreateNode

packages/gatsby-transformer-react-docgen/src/gatsby-node.js

@@ -1,7 +1,4 @@
-const {
-  onCreateNode,
-  unstable_shouldOnCreateNode,
-} = require(`./on-node-create`)
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+const { onCreateNode, shouldOnCreateNode } = require(`./on-node-create`)
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.onCreateNode = onCreateNode
 exports.setFieldsOnGraphQLNodeType = require(`./extend-node-type`).default

packages/gatsby-transformer-react-docgen/src/on-node-create.js

@@ -88,7 +88,7 @@ function createPropNodes(
   return node
 }
 
-export function unstable_shouldOnCreateNode({ node }) {
+export function shouldOnCreateNode({ node }) {
   return canParse(node)
 }
 

packages/gatsby-transformer-remark/src/gatsby-node.js

@@ -1,9 +1,6 @@
-const {
-  onCreateNode,
-  unstable_shouldOnCreateNode,
-} = require(`./on-node-create`)
+const { onCreateNode, shouldOnCreateNode } = require(`./on-node-create`)
 exports.onCreateNode = onCreateNode
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.createSchemaCustomization = require(`./create-schema-customization`)
 exports.setFieldsOnGraphQLNodeType = require(`./extend-node-type`)
 

packages/gatsby-transformer-remark/src/on-node-create.js

@@ -1,7 +1,7 @@
 const grayMatter = require(`gray-matter`)
 const _ = require(`lodash`)
 
-function unstable_shouldOnCreateNode({ node }) {
+function shouldOnCreateNode({ node }) {
   return (
     node.internal.mediaType === `text/markdown` ||
     node.internal.mediaType === `text/x-markdown`
@@ -20,7 +20,7 @@ module.exports.onCreateNode = async function onCreateNode(
   pluginOptions
 ) {
   // We only care about markdown content.
-  if (!unstable_shouldOnCreateNode({ node })) {
+  if (!shouldOnCreateNode({ node })) {
     return {}
   }
 
@@ -81,4 +81,4 @@ module.exports.onCreateNode = async function onCreateNode(
   }
 }
 
-module.exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+module.exports.shouldOnCreateNode = shouldOnCreateNode

packages/gatsby-transformer-screenshot/src/gatsby-node.js

@@ -82,7 +82,7 @@ exports.onPreBootstrap = (
   })
 }
 
-function unstable_shouldOnCreateNode({ node }, pluginOptions) {
+function shouldOnCreateNode({ node }, pluginOptions) {
   /*
    * Check if node is of a type we care about, and has a url field
    * (originally only checked sites.yml, hence including by default)
@@ -91,13 +91,13 @@ function unstable_shouldOnCreateNode({ node }, pluginOptions) {
   return validNodeTypes.includes(node.internal.type) && node.url
 }
 
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 
 exports.onCreateNode = async (
   { node, actions, store, cache, createNodeId, createContentDigest, getCache },
   pluginOptions
 ) => {
-  if (!unstable_shouldOnCreateNode({ node }, pluginOptions)) {
+  if (!shouldOnCreateNode({ node }, pluginOptions)) {
     return
   }
 

packages/gatsby-transformer-sharp/src/gatsby-node.js

@@ -1,7 +1,4 @@
-const {
-  onCreateNode,
-  unstable_shouldOnCreateNode,
-} = require(`./on-node-create`)
+const { onCreateNode, shouldOnCreateNode } = require(`./on-node-create`)
 const { ERROR_MAP } = require(`./error-utils`)
 
 exports.onPreInit = ({ reporter }) => {
@@ -10,6 +7,6 @@ exports.onPreInit = ({ reporter }) => {
   }
 }
 exports.onCreateNode = onCreateNode
-exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+exports.shouldOnCreateNode = shouldOnCreateNode
 exports.createSchemaCustomization = require(`./customize-schema`)
 exports.createResolvers = require(`./create-resolvers`)

packages/gatsby-transformer-sharp/src/on-node-create.js

@@ -1,17 +1,17 @@
 const { supportedExtensions } = require(`./supported-extensions`)
 
-function unstable_shouldOnCreateNode({ node }) {
+function shouldOnCreateNode({ node }) {
   return node.internal.type === `File` && !!supportedExtensions[node.extension]
 }
 
-module.exports.unstable_shouldOnCreateNode = unstable_shouldOnCreateNode
+module.exports.shouldOnCreateNode = shouldOnCreateNode
 
 module.exports.onCreateNode = async function onCreateNode({
   node,
   actions,
   createNodeId,
 }) {
-  if (!unstable_shouldOnCreateNode({ node })) {
+  if (!shouldOnCreateNode({ node })) {
     return
   }