fix(gatsby): Make <script> in Head behave correctly (#36212) #36299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use innerHTML since since text is unesacaped * make scripts run * eliminate multiple append calls * dev inline script test * fix problematic multiple appending * test that script run and get called once * diff nodes before reappending * add new elements and remove stale ones * remove element in prev loop * move node diffind to separate function, add unit test * slightly more performant diffing * don't init array if we will bail early anyway Co-authored-by: pieh <misiek.piechowiak@gmail.com> (cherry picked from commit 6612f69)
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
approved these changes
Aug 2, 2022
This was referenced Dec 14, 2023
This was referenced Dec 14, 2023
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #36212 to the 4.20 release branch
(cherry picked from commit 6612f69)