feat(gatsby, gatsby-plugin-utils, gatsby-source-wordpress, gatsby-source-contentful, gatsby-source-drupal): Add setRequestHeaders action/api #35655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
removed
the
status: triage needed
wardpeet
reviewed
May 13, 2022
…ide fetchRemoteFile
TylerBarnes
commented
May 17, 2022
packages/gatsby-plugin-utils/src/polyfill-remote-file/utils/get-request-headers-for-url.ts
Outdated
Show resolved
Hide resolved
veryspry
previously requested changes
May 18, 2022
…s/gatsby into feat/get-request-headers
TylerBarnes
force-pushed
the
feat/get-request-headers
branch
from
f1438c3
to
a65242b
Compare
veryspry
previously approved these changes
May 26, 2022
|
Hmm, I'm having trouble figuring out why tests are failing. It looks like the tests that are failing are unrelated but it also looks like those tests are only failing for this PR, so some change here must be breaking something else. I'll have to figure that out before we can merge this 🤔 Annoying too because it doesn't fail when running the tests locally |
TylerBarnes
commented
May 28, 2022
packages/gatsby-source-wordpress/__tests__/fetch-referenced-media-items.test.js
Show resolved
Hide resolved
wardpeet
reviewed
May 30, 2022
packages/gatsby-plugin-utils/src/polyfill-remote-file/__tests__/gatsby-image-resolver.ts
Outdated
Show resolved
Hide resolved
wardpeet
reviewed
May 30, 2022
packages/gatsby-source-wordpress/src/steps/set-request-headers.ts
Outdated
Show resolved
Hide resolved
wardpeet
approved these changes
May 31, 2022
veryspry
approved these changes
May 31, 2022
wardpeet
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new public action
setRequestHeadersfor source plugins to use. Any headers set with this action are set for a specific base domain and then Image CDN picks up these headers and uses them when making requests for images/files from that domain.Fixes #35151