fix: add basic auth to image url before passing it to gatsbyImageData #35580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Closed
2 tasks
|
Closing since this was just a sort of POC to prove the cause of a bug |
LekoArts
removed
the
status: triage needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#35151 Points out that
gatsby-source-wordpressbuilds now break when the WordPress instance is behind basic auth. This is because the new image resolver that the source plugin uses,gatsbyPluginImagedoes not pass along basic auth credentials when making requests for images from the WordPress instance.This is because the current fix adds the username/password to the image url in plain text before sending the request. Because
gatsbydoes various things with those urls internally, such as logging them and in some cases persisting them more permanently (e.g. Gatsby Cloud build logs), we need to send these credentials via headers.That latter part of sending the crendentials via headers is incoming, but I wanted to open a WIP PR for discussion etc.