fix(gatsby-cli): Re-Add plugin-add functionality #34482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: cli
LekoArts
commented
Jan 13, 2022
| @@ -0,0 +1,86 @@ | |||
| import reporter from "../reporter" | |||
There was a problem hiding this comment.
Copied from https://github.com/gatsbyjs/gatsby/blob/fb530ecccd45037b664525c5a7d18ea13f64a540/packages/gatsby-cli/src/handlers/plugin-add.ts which was deleted in "Remove recipes" PR
| @@ -0,0 +1,193 @@ | |||
| import * as fs from "fs-extra" | |||
There was a problem hiding this comment.
| @@ -0,0 +1,319 @@ | |||
| import * as t from "@babel/types" | |||
There was a problem hiding this comment.
LekoArts
commented
Jan 14, 2022
|
|
||
| const getValueFromNode = (node: any): any => { | ||
| if (t.isTemplateLiteral(node)) { | ||
| // @ts-ignore - fix me |
There was a problem hiding this comment.
This file has a lot of // @ts-ignore. If you feel strongly about it I can spend time fixing it but I just wanted it to get working 😬
pieh
approved these changes
Jan 14, 2022
marvinjude
pushed a commit
that referenced
this pull request
Jan 17, 2022
(cherry picked from commit 618b32b)
tyhopp
pushed a commit
that referenced
this pull request
Jan 17, 2022
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR #34094 removed
gatsby-cli/lib/handlers/plugin-addsince it seemed unused. Turns out, it's not: It's used increate-gatsby. So I've copied over the bits fromgatsby-recipesthat are needed and re-added it.plugin-addshould be nearly identical to what it was before, the other files are new/copied over.Related Issues
Fixes #34477
[sc-44408]