Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ssr): Fix flakes #34443

Merged
merged 2 commits into from Jan 11, 2022
Merged

test(ssr): Fix flakes #34443

merged 2 commits into from Jan 11, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Jan 11, 2022

Description

Fix a recurrent integration test flake that's been causing some confusion.

Related Issues

[sc-44269]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 11, 2022
@tyhopp tyhopp added topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 11, 2022
@tyhopp tyhopp force-pushed the fix-flaky-ssr-integration-test branch from aabe1d9 to 6ad2085 Compare January 11, 2022 05:09
@tyhopp tyhopp force-pushed the fix-flaky-ssr-integration-test branch from 6ad2085 to 30a9977 Compare January 11, 2022 05:35
@tyhopp tyhopp changed the title fix(integration-tests): Flaky ssr test - WIP test(ssr): Fix flakes Jan 11, 2022
@tyhopp
Copy link
Contributor Author

tyhopp commented Jan 11, 2022

Rerunning tests a couple times to see if it appears again

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try if that fixes it. Thanks!

@LekoArts LekoArts merged commit 49e0710 into master Jan 11, 2022
@LekoArts LekoArts deleted the fix-flaky-ssr-integration-test branch January 11, 2022 09:47
moonmeister added a commit to moonmeister/gatsby that referenced this pull request Jan 11, 2022
* master: (24 commits)
  chore(docs): Release Notes v4.5 (gatsbyjs#34425)
  chore(docs): Update quick-start guide (gatsbyjs#34445)
  chore(docs) : Typo fix GatbsyImage -> GatsbyImage (gatsbyjs#34439)
  perf(gatsby): reuse rootNode & trackedRootNodes caches across instances of graphqlRunner (gatsbyjs#33695)
  Update media-item-processing.md (gatsbyjs#34434)
  chore(docs): Update localization doc (gatsbyjs#34429)
  test(ssr): Fix flakes (gatsbyjs#34443)
  chore(release): Publish next
  Revert "docs: Match egghead.io video instructions (gatsbyjs#34315)" (gatsbyjs#34384)
  fix(gatsby-plugin-manifest): generate icons sequentially (gatsbyjs#34331)
  Fix misspelling of "precedence" in log message (gatsbyjs#34428)
  chore(docs): Adjust doc mentions of gatsby-plugin-create-client-paths (gatsbyjs#34424)
  chore(docs): Update static-folder doc (gatsbyjs#34392)
  Upgrade to strip-ansi ^6.0.1 (gatsbyjs#34383)
  chore(gatsby-plugin-create-client-paths): Update client paths plugin readme with migration info (gatsbyjs#34423)
  chore: Remove deprecated client paths plugin references (gatsbyjs#34422)
  chore(docs): Old occurrences of gatbyjs.org (gatsbyjs#34402)
  Update plugins.md to have correct URL for gatsby-plugin-segment-js (gatsbyjs#34397)
  chore(gatsby): Give option to ignore output from workers and silence validate-engines (gatsbyjs#34416)
  chore(release): Publish next pre-minor
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants