Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini-tutorials for Glamor and Styled Components #3417

Merged
merged 23 commits into from Jan 10, 2018

Conversation

shannonbux
Copy link
Contributor

Do the intros and code examples make sense even though these are now removed from the context of Part Two of the Tutorial?

@ghost ghost assigned shannonbux Jan 4, 2018
@ghost ghost added the review label Jan 4, 2018
@KyleAMathews
Copy link
Contributor

KyleAMathews commented Jan 4, 2018

Deploy preview failed.

Built with commit 23012dc

https://app.netlify.com/sites/using-glamor/deploys/5a53f12d819876157aff98be

@shannonbux shannonbux mentioned this pull request Jan 4, 2018
@benjaminhoffman
Copy link
Contributor

@shannonbux I think the code snippets are definitely still helpful but I will defer to others. Rule of thumb with this stuff, an example is 100x more helpful than an explanation. That's my #1 complaint about most tutes... not enough code snippets.

edits to reflect this page's relationship to Part Two of tutorial
Copy link
Contributor Author

@shannonbux shannonbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this has a few extra docs that I didn't edit. I think it's because I pushed this from my desktop and I'm still learning how to do that.

@benjaminhoffman
Copy link
Contributor

@shannonbux happy to help get this cleaned up... just need a bit more context. If you got it, no worries but if you'd like a hand, send a text and we'll go from there.

shannonbux and others added 6 commits January 8, 2018 15:16
For Glamor and Styled Components pages. Does it make sense to have these in the Guides section?
Let the wars begin about CSS-in-JS!
@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 0f0ad28

https://deploy-preview-3417--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jan 9, 2018

Deploy preview ready!

Built with commit b306e02

https://deploy-preview-3417--gatsbygram.netlify.com

@benjaminhoffman
Copy link
Contributor

yay! you got it! 👍 😄

@ghost ghost assigned KyleAMathews Jan 10, 2018
@KyleAMathews
Copy link
Contributor

Thanks!

@KyleAMathews KyleAMathews merged commit e61959a into gatsbyjs:master Jan 10, 2018
@ghost ghost removed the review label Jan 10, 2018
jastack pushed a commit to jastack/gatsby that referenced this pull request Jan 24, 2018
* Create adding-a-list-of-markdown-blog-posts.md

* Create adding-markdown-pages.md

* Create adding-tags-and-categories-to-blog-posts.md

* Create creating-dynamically-rendered-navigation.md

* Create how-gatsby-works-with-github-pages.md

* Create dropping-images-into-static-folders.md

* Update adding-markdown-pages.md

* Update adding-tags-and-categories-to-blog-posts.md

* Update adding-a-list-of-markdown-blog-posts.md

* new link

* Update dropping-images-into-static-folders.md

* new link

* New mini-tutorials on Glamor and Styled Components

Do the intros and code examples make sense now that these are removed from the context provided by Part Two of the tutorial?

* Fully edited

edits to reflect this page's relationship to Part Two of tutorial

* Updated relative links

* Updated relative links

* New relative links from sidebar

For Glamor and Styled Components pages. Does it make sense to have these in the Guides section?

* CSS-in-JS explanation

Let the wars begin about CSS-in-JS!

* Update glamor.md

* Update styled-components.md

* Update doc-links.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants