Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-recipes): remove duplicate Babel install #32377

Closed
wants to merge 4 commits into from
Closed

chore(gatsby-recipes): remove duplicate Babel install #32377

wants to merge 4 commits into from

Conversation

aaronadamsCA
Copy link
Contributor

Description

Update all mdx-js v2 dependencies to latest, including removal of deprecated package remark-mdxjs.

This should stop installing @babel/core@7.10.5 as a transitive dependency of Gatsby (gatsby -> gatsby-cli -> gatsby-recipes -> remark-mdxjs -> @babel/core@7.10.5).

Documentation

None.

Related Issues

Resolves #31023.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 15, 2021
@aaronadamsCA
Copy link
Contributor Author

aaronadamsCA commented Jul 15, 2021

Tests are failing, but the error messages match existing user reports here:

#22991 (comment)

Based on this in the CircleCI log:

  console.warn packages/gatsby-recipes/node_modules/remark-mdx/index.js:28
    [remark-mdx] Warning: please upgrade to remark 13 to use this plugin

It seems the tests might be running without Remark v13?

I tried adding a dependency from gatsby-recipes to Remark v13, but that didn't work. I'm not sure what's going on here, but it seems like it might be unrelated to the PR.

@gatsbyjs gatsbyjs deleted a comment from gatsbot bot Sep 22, 2021
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 8, 2021
@LekoArts
Copy link
Contributor

LekoArts commented Dec 8, 2021

Hi! I'm closing this in favor of #34094

@LekoArts LekoArts closed this Dec 8, 2021
@aaronadamsCA aaronadamsCA deleted the gatsby-recipes/remove-duplicate-babel-install branch December 8, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-recipes] Remove duplicate Babel install
2 participants