Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Joi in gatsby-recipes #31889

Closed
wants to merge 29 commits into from
Closed

Update Joi in gatsby-recipes #31889

wants to merge 29 commits into from

Conversation

darkmatter18
Copy link

Description

This PR contains all necessary changes that will upgrade the Joi version to 17.4.0. As @hapi/Joi is depricated, so updating Joi is needed to stay up to date and remove all deprecation warnings

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 13, 2021
@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 14, 2021
@gatsbot
Copy link

gatsbot bot commented Jun 26, 2021

Fails
🚫

Danger failed to run /app/peril-downloaded-gatsbyjs/gatsby@peril/rules/validate-yaml.ts.

Error TypeError

Cannot read property 'modified_files' of undefined
TypeError: Cannot read property 'modified_files' of undefined
    at Promise.all.Object.entries.map (/app/peril-downloaded-gatsbyjs/gatsby@peril/rules/validate-yaml.ts:149:25)
    at Array.map (<anonymous>)
    at Object.exports.validateYaml (/app/peril-downloaded-gatsbyjs/gatsby@peril/rules/validate-yaml.ts:148:52)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

144|         twitter: Joi.string().regex(/^@/),
145|       })
146|     )
147|     .unique("id")
148| }
----------------------------^
149| 
150| const getStartersSchema = categories => {
151|   return Joi.array()
152|     .items(

Generated by 🚫 dangerJS

@LekoArts
Copy link
Contributor

LekoArts commented Dec 8, 2021

Hey, thanks for the PR! But we're going to deprecate recipes so I'll close this in favor of #34094

@LekoArts LekoArts closed this Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants