Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Add allowNamespace option to ESLint config #30023

Merged
merged 3 commits into from Mar 25, 2021
Merged

fix(gatsby): Add allowNamespace option to ESLint config #30023

merged 3 commits into from Mar 25, 2021

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Mar 5, 2021 •
edited

Description

Add the allowNamespace option to our default config so that Theme UI isn't warning anymore.
Thanks @Kev-Y-Huang for the upstream PR: jsx-eslint/eslint-plugin-react#2917

Related Issues

Fixes #29287
Fixes #24327

[ch26618]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 5, 2021
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 5, 2021
pieh
pieh previously approved these changes Mar 5, 2021
View reviewed changes
@LekoArts
Copy link
Contributor Author

LekoArts commented Mar 5, 2021

@pieh weird, failing tests 🤔

@pieh
Copy link
Contributor

pieh commented Mar 5, 2021 

Error Generating development JavaScript bundle failed

BaseConfig:
	Configuration for rule "react/jsx-pascal-case" is invalid:
	Value {"allowNamespace":true} should NOT have additional properties.

failed Building development bundle - 17.982s
ERROR in BaseConfig:
	Configuration for rule "react/jsx-pascal-case" is invalid:
	Value {"allowNamespace":true} should NOT have additional properties.

@pieh
Copy link
Contributor

pieh commented Mar 5, 2021

Seems like referenced PR wasn't released yet :(

@pieh pieh dismissed their stale review March 5, 2021 09:56

Dismissing because change in eslint plugin wasn't released yet ;(

@LekoArts LekoArts marked this pull request as draft March 5, 2021 10:01
@LekoArts
Copy link
Contributor Author

LekoArts commented Mar 9, 2021

Closing for now until this is released.

@LekoArts LekoArts closed this Mar 9, 2021
@Kev-Y-Huang
Copy link

@LekoArts just wanted flag that eslint-plugin-react just had a release where the new feature was added

@LekoArts LekoArts reopened this Mar 24, 2021
@LekoArts LekoArts marked this pull request as ready for review March 24, 2021 14:40
@LekoArts LekoArts merged commit 98001eb into master Mar 25, 2021
@LekoArts LekoArts deleted the pc-allow-namespace branch March 25, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

@pieh pieh pieh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@LekoArts @pieh @Kev-Y-Huang @ascorbic