Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): use correct stageLabel instead of undefined #28701

Merged
merged 2 commits into from Dec 19, 2020
Merged

fix(gatsby): use correct stageLabel instead of undefined #28701

merged 2 commits into from Dec 19, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Dec 19, 2020

Description

We've been showing "undefined failed" for webpack compilation errors since #27432 . This fixes regression and add some basic test to hopefully guard against future regressions.

Some before/after for all 4 stages:

Before:

  • build / js bundle
    Screenshot 2020-12-19 at 15 42 49
  • build / ssr bundle
    Screenshot 2020-12-19 at 15 39 36
  • develop / js bundle
    Screenshot 2020-12-19 at 15 41 47
  • develop / ssr bundle
    Screenshot 2020-12-19 at 15 40 31

After:

  • build / js bundle
    Screenshot 2020-12-19 at 15 32 10
  • build / ssr bundle
    Screenshot 2020-12-19 at 15 38 09
  • develop / js bundle
    Screenshot 2020-12-19 at 15 33 51
  • develop / ssr bundle
    Screenshot 2020-12-19 at 15 36 27

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 19, 2020
@pieh pieh added topic: webpack/babel Webpack or babel topic: reporter and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 19, 2020
@pieh pieh merged commit a77e1d8 into master Dec 19, 2020
@pieh pieh deleted the fix/webpack-error-undefined-stagelabel branch December 19, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
topic: webpack/babel Webpack or babel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pieh @KyleAMathews