feat(gatsby-cli): remove feature flag for new interactive gatsby new experience
#28125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
mxstbr
added
topic: cli
ascorbic
reviewed
Nov 26, 2020
| !starterStr && | ||
| !rootPathStr | ||
| ) { | ||
| if (!starterStr && !rootPathStr) { |
There was a problem hiding this comment.
We should eventually handle root path too, skipping the first question
ascorbic
reviewed
Nov 26, 2020
| @@ -27,11 +27,60 @@ You can also use the `package.json` script variant of these commands, typically | |||
|
|
|||
| ### `new` | |||
|
|
|||
| #### Usage | |||
There was a problem hiding this comment.
Does this need updating in Contentful too?
There was a problem hiding this comment.
I don't think these docs live in Contentful 🤔 Either way we should ship this for now and (worst-case scenario) update Contentful afterwards 👍
cc @meganesu
ascorbic
approved these changes
Nov 26, 2020
delete-merged-branch
bot
deleted the
remove-create-gatsby-feature-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added this feature flag in #27954. Once we feel comfortable releasing the new interactive
gatsby newexperience for all our users we should merge this PR to remove the feature flag and update the docs forgatsby new![ch19029]