Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(gatsby-plugin-sass): sass-loader to v10 & default usage of sass #27991

Merged
merged 3 commits into from Dec 16, 2020
Merged

BREAKING(gatsby-plugin-sass): sass-loader to v10 & default usage of sass #27991

merged 3 commits into from Dec 16, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 12, 2020 •
edited by LekoArts

Fixes #27754

Moves the default sass implementation to the Dart one, so documentation was also updated.

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sass-loader ^7.3.1 -> ^10.1.0 age adoption passing confidence

Release Notes

webpack-contrib/sass-loader

v10.1.0

Compare Source

Features
10.0.5 (2020-11-02)
Bug Fixes
10.0.4 (2020-10-22)
Bug Fixes
10.0.3 (2020-10-09)
Chore
  • update schema-utils
10.0.2 (2020-09-03)
Bug Fixes
10.0.1 (2020-08-25)
Chore
  • update deps

v10.0.5

Compare Source

v10.0.4

Compare Source

v10.0.3

Compare Source

v10.0.2

Compare Source

v10.0.1

Compare Source

v10.0.0

Compare Source

Bug Fixes
  • handle absolute windows path in source maps

v9.0.3

Compare Source

v9.0.2

Compare Source

v9.0.1

Compare Source

v9.0.0

Compare Source

⚠ BREAKING CHANGES
  • minimum supported Nodejs version is 10.13
  • prefer sass (dart-sass) by default, it is strongly recommended to migrate on sass (dart-sass)
  • the prependData option was removed in favor the additionalData option, see docs
  • when the sourceMap is true, sassOptions.sourceMap, sassOptions.sourceMapContents, sassOptions.sourceMapEmbed, sassOptions.sourceMapRoot and sassOptions.omitSourceMapUrl will be ignored.
Features
  • pass the loader context to custom importers under the this.webpackLoaderContext property (#​853) (d487683)
  • supports for process.cwd() resolution logic by default (#​837) (0c8d3b3)
  • supports for SASS-PATH env variable resolution logic by default (#​836) (8376179)
  • supports for the sass property for the exports field from package.json (conditional exports, for more information read docs)
Bug Fixes
  • avoid different content on different os (#​832) (68dd278)
  • resolution logic when the includePaths option used was improved (#​827) (cbe5ad4)
  • resolution logic for file:// scheme was improved (17832fd)
  • resolution logic for absolute paths and server relative URLs was improved
  • source maps generation was improved
8.0.2 (2020-01-13)
Bug Fixes
8.0.1 (2020-01-10)
Bug Fixes

v8.0.2

Compare Source

v8.0.1

Compare Source

v8.0.0

Compare Source

⚠ BREAKING CHANGES
  • minimum required webpack version is 4.36.0
  • minimum required node.js version is 8.9.0
  • move all sass (includePaths, importer, functions, outputStyle) options to the sassOptions option. The functions option can't be used as Function, you should use sassOption as Function to achieve this.
  • the data option was renamed to the prependData option
  • default value of the sourceMap option depends on the devtool value (eval/false values don't enable source map generation)
Features
  • automatically use the fibers package if it is possible (#​744) (96184e1)
  • source map generation depends on the devtool option (#​743) (fcea88e)
  • validate loader options (#​737) (7b543fc)
  • reworked error handling from node-sass/sass
  • improve resolution for @import (including support _index and index files in a directory)
Bug Fixes
  • compatibility with pnp
7.3.1 (2019-08-20)
Bug Fixes

@renovate renovate bot requested a review from a team as a code owner November 12, 2020 09:30
@renovate renovate bot added the topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot label Nov 12, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 12, 2020
@Floriferous
Copy link

This will allow updating to node-sass v5, which currently breaks builds if used: webpack-contrib/sass-loader#899

@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 16, 2020
@renovate renovate bot force-pushed the renovate/major-gatsby-plugin-sass-major branch from 4a56616 to 9eb7dc3 Compare November 17, 2020 18:05
@renovate renovate bot force-pushed the renovate/major-gatsby-plugin-sass-major branch from 9eb7dc3 to 68b6be4 Compare November 18, 2020 16:12
@LekoArts LekoArts added the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Nov 30, 2020
@LekoArts LekoArts removed the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Dec 9, 2020
@LekoArts LekoArts added breaking change If implemented, this proposed work would break functionality for older versions of Gatsby topic: sass type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot labels Dec 9, 2020
@LekoArts LekoArts mentioned this pull request Dec 9, 2020
Closed
@LekoArts LekoArts changed the title fix(deps): update dependency sass-loader to v10 for gatsby-plugin-sass BREAKING(gatsby-plugin-sass): sass-loader to v10 & default usage of sass Dec 9, 2020
vladar
vladar approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me but I didn't test this locally.

@ascorbic ascorbic mentioned this pull request Dec 16, 2020
Merged
@LekoArts LekoArts merged commit b2d146b into master Dec 16, 2020
@LekoArts LekoArts deleted the renovate/major-gatsby-plugin-sass-major branch December 16, 2020 11:24
LekoArts added a commit that referenced this pull request Dec 17, 2020
@LekoArts
Revert partially "BREAKING(gatsby-plugin-sass): sass-loader to v10 & …
feeb197 
…default usage of `sass` (#27991)"

This reverts (partially) commit b2d146b
@LekoArts LekoArts mentioned this pull request Dec 17, 2020
Merged
@vladar vladar mentioned this pull request Jan 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
breaking change If implemented, this proposed work would break functionality for older versions of Gatsby type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node Sass version 5.0.0 is incompatible with ^4.0.0.
4 participants
@Floriferous @vladar @LekoArts @renovate-bot