Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-recipes): Add peer dependencies #27155

Closed
wants to merge 1 commit into from
Closed

fix(gatsby-recipes): Add peer dependencies #27155

wants to merge 1 commit into from

Conversation

seniorquico
Copy link

Description

The gatsby-interface package declares gatsby and react-dom peer dependencies, and the gatsby-recipes package depends on gatsby-interface without also declaring gatsby and react-dom peer dependencies. The same goes for an ink peer dependency requested by ink-box. Declaring the peer dependencies resolves a Yarn v2 PNP resolution issue:

➤ YN0002: │ gatsby-recipes@npm:0.2.29 [70091] doesn't provide gatsby@^2.6.0 requested by gatsby-interface@npm:0.0.193
➤ YN0002: │ gatsby-recipes@npm:0.2.29 [70091] doesn't provide react-dom@^16.8.1 requested by gatsby-interface@npm:0.0.193
➤ YN0002: │ gatsby-recipes@npm:0.2.29 [70091] doesn't provide ink@>=2.0.0 requested by ink-box@npm:1.0.0

Related Issues

This addresses just one of the remaining Yarn v2 compatibility issues identified by #20949.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 28, 2020
@pieh pieh added topic: recipes type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 1, 2020
@pieh pieh changed the title Add peer dependencies fix(gatsby-recipes): Add peer dependencies Oct 1, 2020
@LekoArts LekoArts added topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) and removed topic: recipes labels May 28, 2021
@LekoArts
Copy link
Contributor

LekoArts commented Dec 8, 2021

Closing in favor of #34094

@LekoArts LekoArts closed this Dec 8, 2021
@seniorquico seniorquico deleted the patch-2 branch December 9, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seniorquico @LekoArts @pieh