fix(gatsby): Turn off react/jsx-pascal-case in ESLint to fix Theme-UI warnings #24560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
|
I think jsx-eslint/eslint-plugin-react#2638 (recent change to So previously I think the rule is way too opinionated to stay by default, so turning it off in general seems like good idea |
jxnblk
approved these changes
May 28, 2020
|
Thank you @ehowey! |
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
May 28, 2020
… warnings (gatsbyjs#24560) * Turn jsx-pascal-case off * chore: format Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns off
react/jsx-pascal-casein ESLint due to warnings in the console with Theme-UI and the<Styled>component. At the end of the day this isn't a big deal, but it does really clutter up the console when building sites with Theme-UI.Looks like this:
The JSX looks something like this, in case you are not familiar with it:
This may be undesired due to the effect this would have on all users, I believe this was originally off because I didn't used to see these errors and then they suddenly started appearing about a week ago after upgrading Gatsby versions.
I just thought I would make a quick PR in case it helps resolve this issue.
Related to #24327
EDIT: Sorry it looks like my prettier config removed some commas in there, feel free to edit as needed.