Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starters): add gatsby-starter-i18n-bulma #22014

Merged
merged 3 commits into from Mar 9, 2020

Conversation

kalwalt
Copy link
Contributor

@kalwalt kalwalt commented Mar 6, 2020

Description

Proposed starter https://github.com/kalwalt/gatsby-starter-i18n-bulma to add to the starters list

Documentation

The main feature of this starter is the slug switcher for multilanguage. Basically with this system you can have any slug that you want. With i18n plugin you can not change the slug, with it instead let you have a slug in a language, example:

in English:

 /en/about/

in Italian:

/it/presentazione/

The starter is also based on Bulma, Netlify CMS and many more features...

Related Issues

See #14250

@kalwalt kalwalt requested a review from a team as a code owner March 6, 2020 15:02
@kalwalt
Copy link
Contributor Author

kalwalt commented Mar 6, 2020

I don't understand what is to be changed followed this result https://github.com/gatsbyjs/gatsby/runs/490472157 i think i added the tags included in categories.yml but maybe i'am wrong...

I also upgraded gatsby-plugin-sharp gatsby-transformer-sharp gatsby-transformer-sharp to the latest, because the fails in CircleCi build-test

@laurieontech
Copy link
Contributor

Thanks for the PR! It looks like "Media" and "Freelance" are the tags causing this to fail.

@kalwalt
Copy link
Contributor Author

kalwalt commented Mar 6, 2020

Thanks for the PR! It looks like "Media" and "Freelance" are the tags causing this to fail.

Thanks to you @laurieontech ! ok i will remove them. Can you tell me something more about the other errors? I upgraded some pkgs but i think it's needed also to fix other dependencies. It's not included yarn.lock or package-lock.json in the starter so maybe that is the problem...

@kalwalt
Copy link
Contributor Author

kalwalt commented Mar 6, 2020

i found that there is an issue with decompress #21791 the fix is on the way kevva/decompress#73 waiting for the fix.

Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kalwalt! Thanks for the starter and a detailed README with it 🎉

The validation tests failing due to the npm audit will fail for other starts like yours that use similar plugins. From what I understand they actually don't pose a real vulnerability because what's shipped to the browser won't have the vulnerability anyway so I'm going to merge this.

@gillkyle gillkyle merged commit 7771e56 into gatsbyjs:master Mar 9, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 9, 2020

Holy buckets, @kalwalt — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@kalwalt
Copy link
Contributor Author

kalwalt commented Mar 9, 2020

WOW! Thank you @gillkyle @laurieontech very happy for this!

The validation tests failing due to the npm audit will fail for other starts like yours that use similar plugins. From what I understand they actually don't pose a real vulnerability because what's shipped to the browser won't have the vulnerability anyway so I'm going to merge this.

yes, i saw the discussion will see when it will be solved...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants