chore(gatsby-plugin-sharp): move image processing to a worker #19591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a… (gatsbyjs#19582)" This reverts commit 6f4b74d.
wardpeet
changed the title
|
Can you point out the differences between this PR and #18934? |
|
Thanks! (this answer also known as "Mike, read the commit messages" 😅) |
sidharthachatterjee
approved these changes
Nov 18, 2019
|
@wardpeet I have tried v2.3.2 and the total image gatsby tries to generate an increase from ~3000 to ~13000. This behavior starts to show up after I upgrade to the version above 2.3. |
|
@fodkastir, i'm not able to reproduce it. Might be just a visual bug. This should fix it #19717 |
|
I currently have a fix located at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting implementing new jobs api. Move logic to separate worker file so it can run in parallel.
Image processing didn't check the outputFile correctly so re-created all images all over again on each change.
Related Issues
Related to #18934
Fixes #19576