fix(webpack-utils): compact user JS only in production builds #19240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
changed the title
rickiesmooth
pushed a commit
to rickiesmooth/gatsby
that referenced
this pull request
Nov 8, 2019
…js#19240) * fix(webpack-utils): JS is only compacted in production - This line was preventing debugging while using `gatsby develop` - Fixes [issue gatsbyjs#19128](gatsbyjs#19128) * test(webpack-utils): updates snapshot for default cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This line was preventing debugging while using
gatsby develop.By relying on the existing
PRODUCTIONvariable, we ignore compacting in a dev environment.Related Issues
Fixes issue #19128