Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Use options in gatsby-preset & use native loader for deps #15875

Merged
merged 7 commits into from Jul 19, 2019
Merged

chore(gatsby): Use options in gatsby-preset & use native loader for deps #15875

merged 7 commits into from Jul 19, 2019

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Jul 18, 2019 •
edited

Description

Did some benchmarks and tests just to make sure everything was working.
gatsbyjs.org has the biggest difference, I think because they use lots of node_modules.

Tested on moonmeister.net because it uses netlify-cms and we ran into trouble a few times before 😂

Current master:

site #1 #2 #3 avg
starter 7.601s 7.494s 9.700s 8.265s‬
moonmeister.net 14.181s 14.256s 14.096s 14.177s
gatsbyjs.org 52.747s 46.147s 52.273s 50.389s
reactjs.org 21.035s 21.995s 18.251s 20.427s

This pr:

site #1 #2 #3 avg
starter 4.474s 5.798s 5.700s 5.324s‬
moonmeister.net 11.911s 11.731s 11.189s 11.610s
gatsbyjs.org 34.642s 34.384s 34.436s 34.487s
reactjs.org 12.583s 15.258s 15.248s 14.363s

Difference:

site diff %
starter -2.941s -35%
moonmeister.net -2.567s -18%
gatsbyjs.org -15.902s -31%
reactjs.org -6.064s -29%

Related Issues

@wardpeet wardpeet requested a review from a team as a code owner July 18, 2019 16:07
sidharthachatterjee
sidharthachatterjee suggested changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking awesome overall! 🥇

packages/babel-preset-gatsby/src/__tests__/index.js Show resolved Hide resolved
packages/gatsby/src/utils/webpack-utils.js Outdated Show resolved Hide resolved
@sidharthachatterjee sidharthachatterjee changed the title chore: Use options in gatsby-preset & use native loader for deps chore(gatsby): Use options in gatsby-preset & use native loader for deps Jul 18, 2019
@sidharthachatterjee sidharthachatterjee merged commit d1e2f44 into gatsbyjs:master Jul 19, 2019
@sidharthachatterjee
Copy link
Contributor

Published in babel-preset-gatsby@0.2.7 and gatsby@2.13.30

@wKovacs64
Copy link
Contributor

wKovacs64 commented Jul 19, 2019 •
edited

Getting a whole bunch of Cannot find module '@babel/preset-env' from webpack during build after this change, in multiple projects. I can open a new issue, but does that ring any bells?

(Edit: @babel/preset-env is present in node_modules, of course.)

@NathHorrigan NathHorrigan mentioned this pull request Jul 19, 2019
Closed
@KagamiChan
Copy link

seems that this change breaks my gatsby build which used to read configuration babel.config.js

@andrewagain andrewagain mentioned this pull request Jul 26, 2019
Closed
johno pushed a commit to johno/gatsby that referenced this pull request Jul 29, 2019
@wardpeet @johno
chore(gatsby): Use options in gatsby-preset & use native loade… (gats…
f03423e 
…byjs#15875)

* chore: upgrade babel preset tests & use babel options

* use babel-options for stage in js.loader

* don't use custom gatsby babel-loader for dependencies

* fix stage option default

* fix test name

* add v3 comment

* add stage to identifier
@pieh pieh mentioned this pull request Oct 30, 2019
Closed
@wardpeet wardpeet deleted the fix/babel-deps-loader branch September 23, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wardpeet @sidharthachatterjee @wKovacs64 @KagamiChan