Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www) : Add starters library to top navigation menu #15697

Closed
wants to merge 1 commit into from

Conversation

imedadel
Copy link
Contributor

Description

The current navigation menu lacks a link to the starters library, which leads to using the browser's history or searching in google to find the page. This commit would add a link to starters library to make it easier to navigate to the page.

@imedadel imedadel requested a review from a team as a code owner July 14, 2019 10:31
@wardpeet
Copy link
Contributor

Tagging @fk @gatsbyjs/ecosystem @gatsbyjs/docs

@wardpeet wardpeet changed the title chore(docs) : Add starters library to top navigation menu feat(www) : Add starters library to top navigation menu Jul 15, 2019
@wardpeet wardpeet added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Jul 15, 2019
@m-allanson
Copy link
Contributor

Thanks @imedadel - I agree the starters could be more visible, however I'm going to close this PR for now. That's because making this change is more complex than it initially seems, and there's a future project that should improve this part of the site.

This change would need updates to the CSS to ensure the updated navigation fits at all browser widths - currently this code is different for the homepage and the rest of the site. In addition, there's no space at smaller breakpoints to include this in the mobile nav, so it won't be visible to all visitors.

There's a project to make several improvements to gatsbyjs.org, and making sure key parts of the site are discoverable is one of the aims there. See #14017 (although I think it's on hold for the moment).

For the above reasons I will close this. Thank you again for the PR and I hope to see more contributions from you in the future!

@m-allanson m-allanson closed this Jul 15, 2019
@m-allanson m-allanson deleted the ImedAdel-patch-2 branch July 15, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants