Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): don't delete /404.html during development #12297

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Mar 5, 2019

fixes #12249 β€” kinda. I was seeing the / page get deleted while working on .org but then I wasn't able to reproduce it πŸ€·β€β™‚οΈ

I could reproduce this so let's fix this in the meantime :-D

@KyleAMathews KyleAMathews requested a review from a team as a code owner March 5, 2019 01:07
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @KyleAMathews πŸ‘

@sidharthachatterjee sidharthachatterjee merged commit 23488ea into master Mar 5, 2019
@KyleAMathews KyleAMathews deleted the delete-fix branch March 5, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pages created by "stateful" plugins can get deleted (e.g. those in src/pages)
2 participants