Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): Move page component state & side effect handling to xstate #11897

Merged
merged 53 commits into from
Mar 26, 2019
Merged

feat(gatsby): Move page component state & side effect handling to xstate #11897

merged 53 commits into from
Mar 26, 2019

Commits on Feb 19, 2019

  1. Inital work to move component query handling to xstate + fix bug with… 

    … major relay-compilier update
    @KyleAMathews
    KyleAMathews committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    d61316e View commit details
    Browse the repository at this point in the history

  2. Expand model to include we don't want to immediately extract queries … 

    …while bootstrapping + initiate extracting queries from machine when new page component is created
    @KyleAMathews
    KyleAMathews committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    5db0b2c View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. Rearrange states so more in order of possible events

    @KyleAMathews
    KyleAMathews committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    2abcb2c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into xstate-components

    @KyleAMathews
    KyleAMathews committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    799391f View commit details
    Browse the repository at this point in the history

  3. Document two program statuses

    @KyleAMathews
    KyleAMathews committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    bbbd20b View commit details
    Browse the repository at this point in the history

  4. Move responsibility for running queries for pages to the page compone… 

    …nt machine
    @KyleAMathews
    KyleAMathews committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    5f53d33 View commit details
    Browse the repository at this point in the history

  5. Handle page components changing

    @KyleAMathews
    KyleAMathews committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    d8fb163 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. Let state machine know when a query has been run and only re-run quer… 

    …ies if the page query changes
    @KyleAMathews
    KyleAMathews committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    97226e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. Handle babel error state when extracing queries

    @KyleAMathews
    KyleAMathews committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    9347c2f View commit details
    Browse the repository at this point in the history

  2. Make name more explicit

    @KyleAMathews
    KyleAMathews committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    d242435 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. Ignore static query results

    @KyleAMathews
    KyleAMathews committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    a124367 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. Clarify comment

    @KyleAMathews
    KyleAMathews committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    aaf8bf3 View commit details
    Browse the repository at this point in the history

  2. empty strings are falsy 🤦‍♂️

    @KyleAMathews
    KyleAMathews committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    53eea1c View commit details
    Browse the repository at this point in the history

  3. Handled in last commit

    @KyleAMathews
    KyleAMathews committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    0e4d4df View commit details
    Browse the repository at this point in the history

  4. Only handle clean ids for static queries (for now until model static … 

    …queries in a machine as well)
    @KyleAMathews
    KyleAMathews committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    df226de View commit details
    Browse the repository at this point in the history

  5. In hacky/temp way (until modeling pages directly), check if a new pag… 

    …e has been created and run its query
    @KyleAMathews
    KyleAMathews committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    6f60428 View commit details
    Browse the repository at this point in the history

  6. Mark new actions as private

    @KyleAMathews
    KyleAMathews committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    8631558 View commit details
    Browse the repository at this point in the history

  7. Move action to bootstrap per @stefanprobst's suggestion

    @KyleAMathews
    KyleAMathews committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    e5525b4 View commit details
    Browse the repository at this point in the history

  8. Extract page component machine into new 'machines' directory

    @KyleAMathews
    KyleAMathews committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    647b2dd View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. Fix check that there's a query in a non-page component

    @KyleAMathews
    KyleAMathews committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    c3bb339 View commit details
    Browse the repository at this point in the history

  2. Add xstate as a dependency

    @KyleAMathews
    KyleAMathews committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    3e0ddcf View commit details
    Browse the repository at this point in the history

  3. Update snapshots

    @KyleAMathews
    KyleAMathews committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    9343d8e View commit details
    Browse the repository at this point in the history

  4. Add initial tests for page component machine

    @KyleAMathews
    KyleAMathews committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    0e4c346 View commit details
    Browse the repository at this point in the history

  5. Listen for query queue to empty to know queries are done

    @KyleAMathews
    KyleAMathews committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    fd4edaa View commit details
    Browse the repository at this point in the history

  6. Comment out machine logging

    @KyleAMathews
    KyleAMathews committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    50e9b0f View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/master' into xstate-components

    @KyleAMathews
    KyleAMathews committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    0066cad View commit details
    Browse the repository at this point in the history

  8. Restore usage of getCodeFromRelayError

    @KyleAMathews
    KyleAMathews committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    10298a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Don't need to re-set service on Map

    @KyleAMathews
    KyleAMathews committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    b98ea2a View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. Small fixes

    @KyleAMathews
    KyleAMathews committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    836ef5e View commit details
    Browse the repository at this point in the history

  2. Update packages/gatsby/src/redux/reducers/components.js 

    Co-Authored-By: KyleAMathews <mathews.kyle@gmail.com>
    @wardpeet @KyleAMathews
    wardpeet and KyleAMathews committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    3b2006f View commit details
    Browse the repository at this point in the history

  3. Don't run queries until hit query running stage in bootstrap

    @KyleAMathews
    KyleAMathews committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    4f994f6 View commit details
    Browse the repository at this point in the history

  4. Switch page components out of bootstrap state right after bootstrap q… 

    …uery running is finished so if a stateful page changes, new queries are still run
    @KyleAMathews
    KyleAMathews committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    2fb8794 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into xstate-components

    @KyleAMathews
    KyleAMathews committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    1d3074f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. Merge remote-tracking branch 'origin/master' into xstate-components

    @KyleAMathews
    KyleAMathews committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    cb23533 View commit details
    Browse the repository at this point in the history

  2. During bootstrap, only run page queries that are 'clean' (i.e. we hav… 

    …en't seen them before) or 'dirty' (i.e. their tracked nodes changed since the last run)
    @KyleAMathews
    KyleAMathews committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    beebbea View commit details
    Browse the repository at this point in the history

  3. Handle deleting pages in machine so it knows to re-run its query if r… 

    …e-added
    @KyleAMathews
    KyleAMathews committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    17d34d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Move simple set context actions to top-level so don't have to repeat … 

    …across each state (thanks @pieh!)
    @KyleAMathews
    KyleAMathews committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    37baf68 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. Simplify logic for running queries for new pages 

    We only want to run page queries in two circumstances:
- the query has changed
- the data has changed

This is true whether in bootstrap or not.

This commit simplifies the reducer / machine logic to not distinguish
between whether in bootstrap or not.

Also fixes the bug @pieh found where we we're re-running queries in
bootstrap if the query had changed.
    @KyleAMathews
    KyleAMathews committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    5100484 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. run queries for pages created after bootstrap

    @pieh
    pieh committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    a8c32e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Capture more types of graphql extraction errors

    @KyleAMathews
    KyleAMathews committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    9daeae2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into xstate-components

    @DSchau
    DSchau committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    c299ae6 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. DELETE_PAGE action use component not componentPath

    @pieh
    pieh committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    36bda2e View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2019

  1. Page components shouldn't control extraction — moving that to them me… 

    …ant changes to static queries weren't being run
    @KyleAMathews
    KyleAMathews committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    1adc63d View commit details
    Browse the repository at this point in the history

  2. Now that we're not tracking query extracting, add event for when babe… 

    …l successfully extracts queries so we can know to leave babe error state
    @KyleAMathews
    KyleAMathews committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    7932e8e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into xstate-components

    @KyleAMathews
    KyleAMathews committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    f4bb7c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. Merge remote-tracking branch 'origin/master' into xstate-components

    @KyleAMathews
    KyleAMathews committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    20fcf49 View commit details
    Browse the repository at this point in the history

  2. Move graphql/babel event handling to top-level as we should always re… 

    …spond the same way
    @KyleAMathews
    KyleAMathews committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    03f4b37 View commit details
    Browse the repository at this point in the history

  3. Move action call to after findGraphQLTags as we cache babel extraction

    @KyleAMathews
    KyleAMathews committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    8dfe393 View commit details
    Browse the repository at this point in the history

  4. trivial change

    @KyleAMathews
    KyleAMathews committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    cedc761 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. Merge remote-tracking branch 'origin/master' into xstate-components

    @KyleAMathews
    KyleAMathews committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    b3fd97b View commit details
    Browse the repository at this point in the history

  2. yarn.lock change

    @KyleAMathews
    KyleAMathews committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    83eedb2 View commit details
    Browse the repository at this point in the history

  3. Trivial change so can publish

    @KyleAMathews
    KyleAMathews committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    76475f5 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. Update from master

    @KyleAMathews
    KyleAMathews committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    67ef857 View commit details
    Browse the repository at this point in the history