New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): improve hosting with AWS Amplify document #10906
Conversation
I'm not familiar with S3/Amplify but why did you change the current doc and not create a new one? There's currently this PR open to change the doc: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically - this looks good. Excited to have this--been meaning to check out Amplify!
We should probably rename the document though, correct? And then set up a re-direct or re-establish the old "Deploying to S3/Cloudfront" document before it was swapped with the Amplify content.
Is there a reason you wouldn't use Amplify or is there still value in documenting both approaches?
@DSchau @LekoArts nice to meet you guys. Here's my plan for next steps - let me know if you have any comments:
Once you share your thoughts on point number 2 above, I'll go ahead and update the PR. |
https://www.gatsbyjs.org/docs/gatsby-style-guide/#share-best-practices-whenever-possible
Does Amplify completely eliminate the need for S3/Cloudfront? I still feel documenting what #10694 writes is worth it. |
@swaminator I'm totally cool with creating a new document, but I do (still) think it's valuable to keep the documentation for deploying to s3/cloudfront. Perhaps we create a new document here ( Primarily, this is because I'd imagine there are (still) reasons for using s3/cloudfront in certain scenarios? We can highlight/show Amplify as the happy path, but I'm sure there are some who'd set up the infra themselves, so I'd like to keep both if possible. Am I off base here? If so--let me know and we can set up the redirect and get that all ship shape! |
@DSchau: Sounds good to me! It's a good idea to document both approaches as well as highlight that the Amplify Console is the fastest way to setup your Gatsby deployment, but if you want more fine-grained control of your resources, S3/CloudFront is a good option. Questions for you:
Next steps for me: I'll create a file called 'deploying-to-aws-amplify' and update the PR. Please let me know if there's anything else I need to do. |
Hi @swaminator! Just found out about this issue. You're correct in me not being familiar with the Amplify console, and I do agree that it's the 'happy path', but I think in cases where you are still requiring to have control over your own infra (like @DSchau says) |
@jariz that's actually (for some reason) the way the S3 document is currently set up in our repo -> https://github.com/gatsbyjs/gatsby/blob/master/docs/docs/deploying-to-s3-cloudfront.md We should reset it to the way it was (before the introduction of Amplify) but it seems like you're already working on that? So I think the best course of action here is to:
Does anyone disagree? If not--I'll give these both a once over today and get them merged in. Thank you both for your patience! |
Alright - after a barrage of PRs, I think this is ready--presuming the linter passes. What I did was:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only request is in comment I left. Other than that, this looks great! Thanks for putting in the work to make this change!
www/src/data/sidebars/doc-links.yaml
Outdated
@@ -32,8 +32,10 @@ | |||
link: /docs/deploying-to-now/ | |||
- title: Deploying to GitLab Pages | |||
link: /docs/deploying-to-gitlab-pages/ | |||
- title: Hosting on Netlify | |||
- title: Deploying to Netlify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we change the title here, we would need to change it in the doc, the URL, and also create a redirect. It seems like the doc is about hosting though. Am I wrong about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shannonbux I'm not sure there's a meaningful difference--and this seems more consistent (e.g. all deploying guides start with Deploying to-
? I can revert this change, though.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh whoops we actually do have two separate docs here.
Deploying to Netlify
Hosting on Netlify
... should we? It seems like the Hosting on Netlify document is a little more fully featured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually - let's just side step this. I'll revert this change.
(reverted to existing structure; thanks Shannon!)
Alright - finally merging this! Waiting for the status checks to ✅ |
Holy buckets, @swaminator — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
@swaminator merged! Thanks so much for the PR. Really looking forward to checking out Amplify--sometime soon hopefully! |
Thanks @DSchau! Looks good and great working with you. |
* Added AWS Amplify Console * Add AWS Amplify images and gifs * Updated doc to deploying with AWS Amplify * Update AWS Amplify doc link * Update deploying-to-s3-cloudfront.md * Update nav * Added S3 docs from PR: gatsbyjs#10694 and created doc for AWS Amplify deployments * updated docs based on PR feedback * added amplify doc * Reset s3/Cloudfront docs to the current docs * Update deploying-to-aws-amplify.md * Update deploying-to-s3-cloudfront.md * Update deploying-to-aws-amplify.md * Update doc-links.yaml * Update doc-links.yaml * Update deploying-to-aws-amplify.md * Update doc-links.yaml
Description
The Amplify Console (launched at re:invent 2018) provides continuous deployment and hosting for modern web apps (single page apps and static site generators). Continuous deployment allows developers to deploy updates to their web app on every code commit to their Git repository. Hosting includes features such as globally available CDNs, easy custom domain setup + HTTPS, feature branch deployments, and password protection.
This tutorial walks users through deploying a Gatsby starter enabled with authentication to the Amplify Console.