New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-cli): add GATSBY_EXPERIMENTAL_GATSBY_NEW_FLOW flag to use create-gatsby when no options are provided #27954
Conversation
Looking good. It should have the testing banner as long as it's still in alpha. This PR can't come into master until create-gatsby is GA, because it changes the default behaviour of |
We should add a feature flag for now so we can ship it to make sure it works as expected and this PR doesn't sit around forever! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, and subject to Marvin's suggestions I'm happy to see this go in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go for it! 🚢
I really don't think this should affect the CI tests so I'm going to go ahead and merge this since the code is behind a flag anyway and our new release process means it won't even be very publicly facing for a while (even being a Friday afternoon, YOLO) 😬 |
Description
With the new
create-gatsby
package that doesn't use flags and provides an interactive new experience, this removes the old behavior that asked for a developer to choose a starter first when they used thegatsby new
command without any flags or options passed in. Thecreate-gatsby
questions are more suited around use cases, instead of having to research what starter you'd want.This also adds an integration test and changes the docs that mentioned the old interactive behavior.
Note: the
create-gatsby
package at v0.0.0-6 still has a testing banner on it, so maybe we want to bump the package before we merge this? For that reason I'm making this a draft pull request to start.Documentation
I updated the
gatsby-cli
docs to mention this flow instead.Related Issues
Related to #27703 (once it's merged)