Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-cli): add GATSBY_EXPERIMENTAL_GATSBY_NEW_FLOW flag to use create-gatsby when no options are provided #27954

Merged
merged 12 commits into from Nov 13, 2020

Conversation

gillkyle
Copy link
Contributor

Description

With the new create-gatsby package that doesn't use flags and provides an interactive new experience, this removes the old behavior that asked for a developer to choose a starter first when they used the gatsby new command without any flags or options passed in. The create-gatsby questions are more suited around use cases, instead of having to research what starter you'd want.

This also adds an integration test and changes the docs that mentioned the old interactive behavior.

Note: the create-gatsby package at v0.0.0-6 still has a testing banner on it, so maybe we want to bump the package before we merge this? For that reason I'm making this a draft pull request to start.

image

Documentation

I updated the gatsby-cli docs to mention this flow instead.

Related Issues

Related to #27703 (once it's merged)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 10, 2020
@gillkyle gillkyle added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 10, 2020
@ascorbic
Copy link
Contributor

Looking good. It should have the testing banner as long as it's still in alpha. This PR can't come into master until create-gatsby is GA, because it changes the default behaviour of gatsby new. A feature flag is one possibility

@mxstbr
Copy link
Contributor

mxstbr commented Nov 11, 2020

We should add a feature flag for now so we can ship it to make sure it works as expected and this PR doesn't sit around forever! GATSBY_EXPERIMENTAL_GATSBY_NEW_FLOW=true?

@gillkyle
Copy link
Contributor Author

Thanks for the suggestions 🙂 I just updated to add a GATSBY_EXPERIMENTAL_GATSBY_NEW_FLOW flag.

Screenshot
image

@gillkyle gillkyle changed the title feat(gatsby-cli): adjust gatsby new logic to use create-gatsby when no options are provided feat(gatsby-cli): add GATSBY_EXPERIMENTAL_GATSBY_NEW_FLOW flag to use create-gatsby when no options are provided Nov 12, 2020
@gillkyle gillkyle marked this pull request as ready for review November 12, 2020 18:21
ascorbic
ascorbic previously approved these changes Nov 13, 2020
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and subject to Marvin's suggestions I'm happy to see this go in

mxstbr
mxstbr previously approved these changes Nov 13, 2020
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 💯

@gillkyle gillkyle dismissed stale reviews from mxstbr and ascorbic via 062286e November 13, 2020 16:15
mfrachet
mfrachet previously approved these changes Nov 13, 2020
Copy link
Contributor

@mfrachet mfrachet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it! 🚢

@gillkyle
Copy link
Contributor Author

gillkyle commented Nov 13, 2020

I really don't think this should affect the CI tests so I'm going to go ahead and merge this since the code is behind a flag anyway and our new release process means it won't even be very publicly facing for a while (even being a Friday afternoon, YOLO) 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cli Related to the Gatsby CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants