fix(actions): fix PR bot action via await on each report call (#15665)

* fix: await each report and protect access to requested reviewer

* fix: better promise structure based on wards suggestions

* Update .github/actions/high-priority-prs/src/index.js

Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>

.github/actions/high-priority-prs/src/filter.js

@@ -10,7 +10,11 @@ const filter = (queues, team) => {
   Object.keys(queues).forEach(key => {
     filteredQueues[key] = queues[key].filter(pr => {
       return pr.reviewRequests.nodes
-        .map(node => node.requestedReviewer.id)
+        .map(node => {
+          if (node.requestedReviewer) {
+            return node.requestedReviewer.id
+          }
+        })
         .includes(team.id)
     })
   })

.github/actions/high-priority-prs/src/index.js

@@ -19,15 +19,15 @@ const start = async function() {
   const data = await fetch()
   if (data) {
     const queues = processData(data)
-    teams.forEach(team => {
+    await Promise.all(teams.map(team => {
       if (team.name === `core`) {
         // send report of all PRs (without filtering) to Core
-        report({ queues, channelId: team.channelId })
+        return report({ queues, channelId: team.channelId })
       } else {
         // send filtered reports to respective teams
-        report(filter(queues, team))
+        return report(filter(queues, team))
       }
-    })
+    }))
   }
 }
 

.github/actions/high-priority-prs/src/process-data.js

@@ -89,6 +89,10 @@ const maintainers = {
     name: "Kyle Gill",
     slackUsername: "@kylegill",
   },
+  "https://github.com/amberleyromo": {
+    name: "Amberley Romo",
+    slackUsername: "@amberley",
+  },
 }
 
 const ignoreMessages = ["Merge branch 'master'", "Merge remote-tracking branch"]