Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add captureBeyondViewport flag for Puppeteer #1374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saitho
Copy link

@saitho saitho commented Nov 12, 2021

Since v5.3.7 Puppeteer does not capture beyond viewport anymore, which could cause some issues for people relying on it.
A new flag captureBeyondViewport for toggling that setting is introduced in BackstopJS configuration as discussed in #1344.

@saitho
Copy link
Author

saitho commented Nov 12, 2021

@garris I was wondering, is there a documentation on available engineOptions?
I wanted to add the new flag but didn't find any documentation on that. :(

@garris
Copy link
Owner

garris commented Nov 12, 2021

Hi @saitho -- the engineOptions props are pretty much passed directly into puppeteer...

config.engineOptions

image

For more information about how this can be used you can look at Puppeteer documentation.

@garris
Copy link
Owner

garris commented Nov 12, 2021

@saitho Does this new config option mean that we do not need this hack anymore?

e3a80e2

@saitho
Copy link
Author

saitho commented Nov 12, 2021

@saitho Does this new config option mean that we do not need this hack anymore?

No, it just allows the user to toggle captureBeyondViewport.
I want to use BackstopJS to do regression tests on a styleguide generated via kss-node.
I need to set captureBeyondViewport: true for it to work properly, as visibility in a viewport is not important here.

Oh I see, config.engineOptions is used there. I thought config was already the engineOptions.
Then my description is wrong. I'll change that. This is not a puppeteer setting, but a new BackstopJS setting.

Since v5.3.7 Puppeteer does not capture beyond viewport anymore, which could cause some issues for people relying on it.
A new flag `captureBeyondViewport` for toggling that setting is introduced in BackstopJS settings as discussed in garris#1344.
@saitho saitho force-pushed the feature/captureBeyondViewportFlag branch from e3a80e2 to e268e99 Compare November 16, 2021 07:37
@saitho
Copy link
Author

saitho commented Nov 16, 2021

I adjusted the commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants